Bug 148093

Summary:

Simplify how PlatformWebViews are created when view options change

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

148154, 148528, 148529, 148927

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	sam: review+

Description Anders Carlsson 2015-08-17 14:17:38 PDT

Simplify how PlatformWebViews are created when view options change

Comment 1 Anders Carlsson 2015-08-17 14:31:04 PDT

Created attachment 259184 [details]
Patch

Comment 2 Anders Carlsson 2015-08-17 14:58:21 PDT

Created attachment 259193 [details]
Patch

Comment 3 Anders Carlsson 2015-08-17 15:49:46 PDT

Committed r188548: <http://trac.webkit.org/changeset/188548>

Comment 4 Csaba Osztrogonác 2015-09-07 04:45:50 PDT

Comment on attachment 259193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259193&action=review

> Tools/WebKitTestRunner/TestController.cpp:755
> -    if (test.urlContains("device-adapt/") || test.urlContains("device-adapt\\"))
> -        return true;
> +        if (test.urlContains("device-adapt/") || test.urlContains("device-adapt\\"))
> +            return true;

bad indentation

> Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:144
> +static bool shouldUseFixedLayout(const TestInvocation& test)
> +{
> +#if USE(COORDINATED_GRAPHICS)
> +    if (test.urlContains("sticky/") || test.urlContains("sticky\\"))
> +        return true;
> +#endif
> +    return false;
> +}
> +

It is obviously wrong, because it returns false for device-adapt tests.

Comment 5 Csaba Osztrogonác 2015-09-07 04:46:29 PDT

(In reply to comment #4)
> Comment on attachment 259193 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259193&action=review
> 
> > Tools/WebKitTestRunner/TestController.cpp:755
> > -    if (test.urlContains("device-adapt/") || test.urlContains("device-adapt\\"))
> > -        return true;
> > +        if (test.urlContains("device-adapt/") || test.urlContains("device-adapt\\"))
> > +            return true;
> 
> bad indentation
> 
> > Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:144
> > +static bool shouldUseFixedLayout(const TestInvocation& test)
> > +{
> > +#if USE(COORDINATED_GRAPHICS)
> > +    if (test.urlContains("sticky/") || test.urlContains("sticky\\"))
> > +        return true;
> > +#endif
> > +    return false;
> > +}
> > +
> 
> It is obviously wrong, because it returns false for device-adapt tests.

Please check bug148927 which tries to fix the regression this patch caused.