| Summary: | WTF::Condition should have a fast path for notifyOne/notifyAll that avoids calling unparkOne/unparkAll | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | Web Template Framework | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, basile_clement, benjamin, cmarcelo, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam | ||||
| Priority: | P2 | ||||||
| Version: | Other | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Filip Pizlo
2015-08-17 13:28:08 PDT
Created attachment 259291 [details]
the patch
Attachment 259291 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/Condition.h:153: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 259291 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=259291&action=review r=me > Source/WTF/wtf/Condition.h:72 > + // Let everyone know that we will be waiting. Do this why we hold the queue lock, why => while > Source/WTF/wtf/Condition.h:167 > + // guaranteed to then notifyAll() anyway. So, if there is a race with some thread calling notifyAll => unparkAll. (In reply to comment #3) > Comment on attachment 259291 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259291&action=review > > r=me > > > Source/WTF/wtf/Condition.h:72 > > + // Let everyone know that we will be waiting. Do this why we hold the queue lock, > > why => while > > > Source/WTF/wtf/Condition.h:167 > > + // guaranteed to then notifyAll() anyway. So, if there is a race with some thread calling > > notifyAll => unparkAll. Fixed, thanks! Landed in http://trac.webkit.org/changeset/188605 |