Bug 148077 – Web Inspector: split TestStub.js into multiple files and modernize it

• Component: Web Inspector
• Status: RESOLVED FIXED

[Blaze Burg]

,

[Radar WebKit Bug Importer]

<rdar://problem/22307794>

[Blaze Burg]

Created attachment 259153 [details]
Proposed Fix

This patch renames some things that were moved around in the dependent patch, so it won't apply.

[Blaze Burg]

Created attachment 259158 [details]
Proposed Fix

[Blaze Burg]

Created attachment 259182 [details]
Make sure non-Mac works

[Blaze Burg]

Committed r188544: <http://trac.webkit.org/changeset/188544>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 148122

[Alexey Proskuryakov]

Rolled out because this depended on r188539.

[Blaze Burg]

Created attachment 259307 [details]
Proposed Fix (with arrows)

Since I have to re-land this patch, I tried adding arrows to the affected code. Please re-review for style, and I'll summarize some things I ran into for the style guide.

[Build Bot]

Comment on attachment 259307 [details]
Proposed Fix (with arrows)

Attachment 259307 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/73301

New failing tests:
inspector/dom/dom-search.html
inspector/dom/dom-search-with-context.html

[Build Bot]

Created attachment 259316 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 259307 [details]
Proposed Fix (with arrows)

Attachment 259307 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/73306

New failing tests:
inspector/dom/dom-search.html
inspector/dom/dom-search-with-context.html

[Build Bot]

Created attachment 259318 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Blaze Burg]

Created attachment 259333 [details]
Proposed Fix (with arrows)

[Blaze Burg]

Created attachment 259352 [details]
Proposed Fix (with arrows)

[Timothy Hatcher]

Comment on attachment 259352 [details]
Proposed Fix (with arrows)

View in context: https://bugs.webkit.org/attachment.cgi?id=259352&action=review

> Source/WebInspectorUI/UserInterface/Test/InspectorProtocol.js:139
> +    // Otherwise, it is an event.
> +    } else {

I'd flip the order of these lines and indent the comment one more level.

> Source/WebInspectorUI/UserInterface/Test/InspectorProtocol.js:150
> +            handler.map(function(listener) {
> +                listener.call(null, messageObject);
> +            });

Arrow.

> Source/WebInspectorUI/UserInterface/Test/Test.js:234
> +        .then(function() {

Arrow?

[Blaze Burg]

Comment on attachment 259352 [details]
Proposed Fix (with arrows)

View in context: https://bugs.webkit.org/attachment.cgi?id=259352&action=review

>> Source/WebInspectorUI/UserInterface/Test/Test.js:234
>> +        .then(function() {
> 
> Arrow?

This file gets rewritten in the next patch, so not fixing here.

[Blaze Burg]

Committed r188639: <http://trac.webkit.org/changeset/188639>