Summary: | [CSS Grid Layout] Relayout whenever Box Alignment properties change | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> | ||||||
Component: | Layout and Rendering | Assignee: | Javier Fernandez <jfernandez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, darin, esprehn+autocc, glenn, hyatt, jfernandez, kondapallykalyan, rego, svillar | ||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 60731, 91512 | ||||||||
Attachments: |
|
Description
Javier Fernandez
2015-08-16 15:24:05 PDT
Created attachment 260054 [details]
Patch
Comment on attachment 260054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260054&action=review r- > Source/WebCore/rendering/RenderGrid.cpp:285 > + child->setChildNeedsLayout(); This should change to: child->setChildNeedsLayout(MarkOnlyThis). Shouldn't positioned objects be skipped by the for loop? It seems like you are checking all children, but don't you only need to check children that are actually part of the grid? Created attachment 260879 [details]
Patch
Comment on attachment 260879 [details] Patch Clearing flags on attachment: 260879 Committed r189910: <http://trac.webkit.org/changeset/189910> All reviewed patches have been landed. Closing bug. |