Bug 148051

Summary: [JSC] Use (x + x) instead of (x * 2) when possible
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Benjamin Poulain 2015-08-14 21:12:14 PDT
[JSC] Use (x + x) instead of (x * 2) when possible
Comment 1 Benjamin Poulain 2015-08-14 21:19:50 PDT
Created attachment 259081 [details]
Patch
Comment 2 Benjamin Poulain 2015-08-14 21:22:32 PDT
                                                  Conf#1                    Conf#2                                      
Octane:
   encrypt                                   0.19307+-0.00492    ?     0.19479+-0.00376       ?
   decrypt                                   3.21916+-0.04500          3.19699+-0.01128       
   deltablue                        x2       0.15060+-0.00200          0.15000+-0.00160       
   earley                                    0.30010+-0.00440    ?     0.30328+-0.00512       ? might be 1.0106x slower
   boyer                                     4.32425+-0.03066    ?     4.34306+-0.03307       ?
   navier-stokes                    x2       4.78825+-0.01134          4.78168+-0.01166       
   raytrace                         x2       1.94752+-0.02467    ?     1.95658+-0.03069       ?
   richards                         x2       0.09647+-0.00091          0.09622+-0.00052       
   splay                            x2       0.39069+-0.00391          0.38897+-0.00442       
   regexp                           x2      24.17738+-0.39770    ^    23.41245+-0.21825       ^ definitely 1.0327x faster
   pdfjs                            x2      36.87037+-0.66745         36.80840+-0.47628       
   mandreel                         x2      42.98668+-0.73428         42.98298+-0.51815       
   gbemu                            x2      31.88557+-0.87645    ?    31.99621+-0.76491       ?
   closure                                   0.53169+-0.00176          0.52997+-0.00224       
   jquery                                    6.72329+-0.01997    ?     6.74090+-0.03508       ?
   box2d                            x2       9.52269+-0.07903          9.50500+-0.06250       
   zlib                             x2     384.55828+-4.04459        375.41807+-13.65940        might be 1.0243x faster
   typescript                       x2     627.55078+-18.46505   ?   632.15210+-8.83752       ?

   <geometric>                               5.75506+-0.02504          5.73647+-0.02634         might be 1.0032x faster

                                                  Conf#1                    Conf#2                                      
Kraken:
   ai-astar                                  222.032+-4.782            219.290+-5.384           might be 1.0125x faster
   audio-beat-detection                       48.832+-0.176      ?      48.878+-0.185         ?
   audio-dft                                  89.394+-0.315             89.356+-0.374         
   audio-fft                                  33.654+-0.074      ?      33.838+-0.291         ?
   audio-oscillator                           59.131+-0.377             59.045+-0.250         
   imaging-darkroom                           57.616+-0.632      ?      57.961+-0.656         ?
   imaging-desaturate                         52.292+-0.089             50.536+-2.017           might be 1.0348x faster
   imaging-gaussian-blur                      79.488+-0.643      ?      79.663+-0.600         ?
   json-parse-financial                       36.272+-0.226      ?      36.611+-0.296         ?
   json-stringify-tinderbox                   23.461+-0.201      ^      21.537+-0.569         ^ definitely 1.0893x faster
   stanford-crypto-aes                        40.015+-0.246      ?      40.280+-0.607         ?
   stanford-crypto-ccm                        32.646+-1.058      ?      32.968+-0.836         ?
   stanford-crypto-pbkdf2                     90.473+-0.399             90.407+-0.272         
   stanford-crypto-sha256-iterative           35.099+-0.394             34.811+-0.290         

   <arithmetic>                               64.315+-0.376             63.941+-0.365           might be 1.0058x faster

                                                  Conf#1                    Conf#2                                      
Geomean of preferred means:
   <scaled-result>                           19.2387+-0.0758           19.1517+-0.0592          might be 1.0045x faster
Comment 3 Saam Barati 2015-08-14 23:17:20 PDT
Comment on attachment 259081 [details]
Patch

r=me
Comment 4 Michael Saboff 2015-08-15 08:49:02 PDT
Comment on attachment 259081 [details]
Patch

r=me
Comment 5 Benjamin Poulain 2015-08-16 01:14:13 PDT
Comment on attachment 259081 [details]
Patch

Clearing flags on attachment: 259081

Committed r188519: <http://trac.webkit.org/changeset/188519>
Comment 6 Benjamin Poulain 2015-08-16 01:14:18 PDT
All reviewed patches have been landed.  Closing bug.