| Summary: | Clean up js-test use in scroll-snap tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2015-08-14 16:41:30 PDT
Created attachment 259057 [details]
proposed patch
Comment on attachment 259057 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=259057&action=review Thank you for cleaning these up! r=me. > LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders-expected.txt:2 > + Testing scroll-snap glide for horizontalTarget: I wonder why there is this extra space here? Comment on attachment 259057 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=259057&action=review >> LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders-expected.txt:2 >> + Testing scroll-snap glide for horizontalTarget: > > I wonder why there is this extra space here? There was already a space in the first output line (" PASS successfullyParsed is true"), so it's not a regression from this patch. It comes from a div, although I'm not entirely sure why WebCore decides to serialize in div into a space. I agree that this looks weird. Comment on attachment 259057 [details] proposed patch Clearing flags on attachment: 259057 Committed r188509: <http://trac.webkit.org/changeset/188509> All reviewed patches have been landed. Closing bug. |