Bug 148024

Summary:

[Win] Cleanups to PluginView::handleMouseEvent()

Product:

WebKit

Reporter:

Sungmann Cho <sungmann.cho>

Component:

WebKit Misc.

Assignee:

Sungmann Cho <sungmann.cho>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, gyuyoung.kim

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Sungmann Cho 2015-08-14 02:16:26 PDT

SSIA

Comment 1 Sungmann Cho 2015-08-14 02:39:46 PDT

1. Replace the raw values identifying specific mouse buttons with WebCore::MouseButton enum values.
2. Reindent if and switch statements.

Comment 2 Sungmann Cho 2015-08-14 02:42:58 PDT

Created attachment 258997 [details]
Patch

Comment 3 Gyuyoung Kim 2015-08-16 20:04:18 PDT

CC'ing Alex, Brent who are responsible for Win port.

Comment 4 Alex Christensen 2015-08-17 09:56:06 PDT

Comment on attachment 258997 [details]
Patch

Cleaner code!  Yay!

Comment 5 WebKit Commit Bot 2015-08-17 10:41:50 PDT

Comment on attachment 258997 [details]
Patch

Clearing flags on attachment: 258997

Committed r188525: <http://trac.webkit.org/changeset/188525>

Comment 6 WebKit Commit Bot 2015-08-17 10:41:55 PDT

All reviewed patches have been landed.  Closing bug.