Bug 148024

Summary: [Win] Cleanups to PluginView::handleMouseEvent()
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: WebKit Misc.Assignee: Sungmann Cho <sungmann.cho>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sungmann Cho
Reported 2015-08-14 02:16:26 PDT
SSIA
Attachments
Patch (3.73 KB, patch)
2015-08-14 02:42 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sungmann Cho
Comment 1 2015-08-14 02:39:46 PDT
1. Replace the raw values identifying specific mouse buttons with WebCore::MouseButton enum values. 2. Reindent if and switch statements.
Sungmann Cho
Comment 2 2015-08-14 02:42:58 PDT
Created attachment 258997 [details] Patch
Gyuyoung Kim
Comment 3 2015-08-16 20:04:18 PDT
CC'ing Alex, Brent who are responsible for Win port.
Alex Christensen
Comment 4 2015-08-17 09:56:06 PDT
Comment on attachment 258997 [details] Patch Cleaner code! Yay!
WebKit Commit Bot
Comment 5 2015-08-17 10:41:50 PDT
Comment on attachment 258997 [details] Patch Clearing flags on attachment: 258997 Committed r188525: <http://trac.webkit.org/changeset/188525>
WebKit Commit Bot
Comment 6 2015-08-17 10:41:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.