Bug 148000

Summary: Remove some includes from Node.cpp
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2015-08-13 16:13:12 PDT
Remove some includes from Node.app
Attachments
Patch (2.20 KB, patch)
2015-08-13 16:13 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2015-08-14 11:38 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-08-13 16:13:44 PDT
Created attachment 258948 [details] Patch
WebKit Commit Bot
Comment 2 2015-08-13 16:16:47 PDT
Comment on attachment 258948 [details] Patch Rejecting attachment 258948 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 258948, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: WS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Anders Carlsson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/ChangeLog.rej patching file Source/WebCore/dom/Node.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Anders Carlsson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/55625
Simon Fraser (smfr)
Comment 3 2015-08-14 11:38:10 PDT
Created attachment 259011 [details] Patch
WebKit Commit Bot
Comment 4 2015-08-17 10:15:23 PDT
Comment on attachment 259011 [details] Patch Clearing flags on attachment: 259011 Committed r188524: <http://trac.webkit.org/changeset/188524>
WebKit Commit Bot
Comment 5 2015-08-17 10:15:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.