Bug 147997

Summary: AppScale: Assertion hit when hovering a webkit-queue bubble
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: WebKit WebsiteAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Minor CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
ap: review-, ap: commit-queue-
Proposed patch none

Aakash Jain
Reported 2015-08-13 15:52:37 PDT
console.assert(this.statusPageURL === data.status_page); Steps to reproduce: 1. Open https://build.webkit.org/dashboard 2. Open Web Inspector 3. Hover a commit queue or EWS bubble.
Attachments
Proposed patch (1.49 KB, patch)
2015-08-13 16:22 PDT, Aakash Jain 		ap: review-
ap: commit-queue-
DetailsFormatted DiffDiff
Proposed patch (1.49 KB, patch)
2015-08-13 16:48 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2015-08-13 16:22:25 PDT
Created attachment 258950 [details] Proposed patch
Alexey Proskuryakov
Comment 2 2015-08-13 16:34:31 PDT
Comment on attachment 258950 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=258950&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:136 > + console.assert(this.statusPageURL.replace(/.*?:\/\//g, "") === data.status_page.replace(/.*?:\/\//g, "")); This replace removes anything before a colon, which I think is incorrect. E.g. "foo://bar://baz".replace(/.*?:\/\//g, "") -> "baz". How about something like "/^https?://" ?
Aakash Jain
Comment 3 2015-08-13 16:48:53 PDT
Created attachment 258954 [details] Proposed patch good point. made the change.
WebKit Commit Bot
Comment 4 2015-08-13 17:01:46 PDT
Comment on attachment 258954 [details] Proposed patch Clearing flags on attachment: 258954 Committed r188419: <http://trac.webkit.org/changeset/188419>
WebKit Commit Bot
Comment 5 2015-08-13 17:01:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.