| Summary: | Use WKPageConfigurationRef in WebKitTestRunner | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||||||||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | thorton | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Anders Carlsson
2015-08-13 15:49:23 PDT
Created attachment 258944 [details]
Patch
Created attachment 258947 [details]
Patch
Created attachment 258959 [details]
Patch
Comment on attachment 258959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258959&action=review > Tools/WebKitTestRunner/TestController.h:235 > WKRetainPtr<WKContextRef> m_context; > WKRetainPtr<WKPageGroupRef> m_pageGroup; Since you can get the context and page group from the configuration, is it worth storing them here? Comment on attachment 258959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258959&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKView.h:-57 > -#if TARGET_OS_IPHONE > -- (id)initWithFrame:(CGRect)frame processGroup:(WKProcessGroup *)processGroup browsingContextGroup:(WKBrowsingContextGroup *)browsingContextGroup; > -- (id)initWithFrame:(CGRect)frame processGroup:(WKProcessGroup *)processGroup browsingContextGroup:(WKBrowsingContextGroup *)browsingContextGroup relatedToView:(WKView *)relatedView; > -#else Can we do this in another patch? > Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:39 > -- (id)initWithFrame:(CGRect)frame contextRef:(WKContextRef)contextRef pageGroupRef:(WKPageGroupRef)pageGroupRef; > -- (id)initWithFrame:(CGRect)frame contextRef:(WKContextRef)contextRef pageGroupRef:(WKPageGroupRef)pageGroupRef relatedToPage:(WKPageRef)relatedPage; > +- (id)initWithFrame:(CGRect)frame configurationRef:(WKPageConfigurationRef)configuration; Can we do this in another patch? > Source/WebKit2/UIProcess/API/mac/WKView.mm:4007 > - Ref<API::PageConfiguration> configuration = *toImpl(configurationRef); > + Ref<API::PageConfiguration> configuration = toImpl(configurationRef)->copy(); This is a good change, but unrelated. Can you break it out? Created attachment 259520 [details]
Patch
Created attachment 259522 [details]
Patch
Created attachment 259526 [details]
Patch
|