Bug 147970

Summary: FilterOperation.h should not include FilterEffect.h
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, kondapallykalyan, ossy, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Description Simon Fraser (smfr) 2015-08-12 23:15:38 PDT
FilterOperation.h should not include FilterEffect.h
Comment 1 Simon Fraser (smfr) 2015-08-12 23:17:04 PDT
Created attachment 258880 [details]
Patch
Comment 2 Alexey Proskuryakov 2015-08-13 00:02:49 PDT
iOS is red.
Comment 3 Daniel Bates 2015-08-13 09:31:39 PDT
Comment on attachment 258880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258880&action=review

> Source/WebCore/platform/graphics/filters/FilterOperation.cpp:69
> +void ReferenceFilterOperation::setFilterEffect(PassRefPtr<FilterEffect> filterEffect)

We should change PassRefPtr<> to RefPtr<>&&. This can be done in a separate bug.
Comment 4 Simon Fraser (smfr) 2015-08-13 16:16:20 PDT
http://trac.webkit.org/changeset/188389
Comment 5 Csaba Osztrogon√°c 2015-08-14 13:17:49 PDT
(In reply to comment #4)
> http://trac.webkit.org/changeset/188389

It broke the EFL build.