Bug 147970

Summary: FilterOperation.h should not include FilterEffect.h
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, kondapallykalyan, ossy, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Simon Fraser (smfr)
Reported 2015-08-12 23:15:38 PDT
FilterOperation.h should not include FilterEffect.h
Attachments
Patch (3.14 KB, patch)
2015-08-12 23:17 PDT, Simon Fraser (smfr) 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-08-12 23:17:04 PDT
Created attachment 258880 [details] Patch
Alexey Proskuryakov
Comment 2 2015-08-13 00:02:49 PDT
iOS is red.
Daniel Bates
Comment 3 2015-08-13 09:31:39 PDT
Comment on attachment 258880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258880&action=review > Source/WebCore/platform/graphics/filters/FilterOperation.cpp:69 > +void ReferenceFilterOperation::setFilterEffect(PassRefPtr<FilterEffect> filterEffect) We should change PassRefPtr<> to RefPtr<>&&. This can be done in a separate bug.
Simon Fraser (smfr)
Comment 4 2015-08-13 16:16:20 PDT
http://trac.webkit.org/changeset/188389
Csaba Osztrogonác
Comment 5 2015-08-14 13:17:49 PDT
(In reply to comment #4) > http://trac.webkit.org/changeset/188389 It broke the EFL build.
Note You need to log in before you can comment on or make changes to this bug.