Summary: | FilterOperation.h should not include FilterEffect.h | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dino, kondapallykalyan, ossy, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2015-08-12 23:15:38 PDT
Created attachment 258880 [details]
Patch
iOS is red. Comment on attachment 258880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258880&action=review > Source/WebCore/platform/graphics/filters/FilterOperation.cpp:69 > +void ReferenceFilterOperation::setFilterEffect(PassRefPtr<FilterEffect> filterEffect) We should change PassRefPtr<> to RefPtr<>&&. This can be done in a separate bug. (In reply to comment #4) > http://trac.webkit.org/changeset/188389 It broke the EFL build. |