|Summary:||Add support for CheckWatchdogTimer as slow path in DFG and FTL.|
|Product:||WebKit||Reporter:||Mark Lam <mark.lam>|
|Severity:||Normal||CC:||benjamin, fpizlo, ggaren, keith_miller, mmirman, msaboff, saam|
|Version:||528+ (Nightly build)|
|Bug Depends on:||148125|
Description Mark Lam 2015-08-12 22:19:08 PDT
Since we don't currently enable the JSC watchdog by default, Web Worker's terminate() function doesn't actually do anything. We should fix this.
Comment 1 Mark Lam 2015-08-14 14:03:37 PDT
Per discussion with Geoff, we can fix this by always enabling the watchdog without a time limit for Web Workers. But before we do that, we should teach the FTL to check the watchdog when present. Since the FTL watchdog support is mostly motivated by the need in Web Workers, I'll tackle the FTL in this bug as well.
Comment 2 Mark Lam 2015-08-18 01:32:44 PDT
Will just implement the FTL support (and improve the DFG support) in this bug. Will add the Worker threads watchdog in 131082 instead where we re-work how Watchdog's m_didFire works.
Comment 4 Michael Saboff 2015-08-19 14:03:55 PDT
Comment 5 Michael Saboff 2015-08-19 14:04:14 PDT
Comment on attachment 259302 [details] the fix. r=me
Comment 6 Mark Lam 2015-08-19 14:09:44 PDT