Bug 147964

Summary: [Cocoa] [CJK-configured device] System font has vertical punctuation
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch dino: review+

Myles C. Maxfield
Reported 2015-08-12 18:28:12 PDT
[Cocoa] Force the system font to use horizontal glyphs
Attachments
WIP (7.88 KB, patch)
2015-08-12 18:43 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (9.15 KB, patch)
2015-08-12 18:52 PDT, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-08-12 18:43:53 PDT
Created attachment 258869 [details] WIP
Myles C. Maxfield
Comment 2 2015-08-12 18:52:15 PDT
Created attachment 258873 [details] Patch
Dean Jackson
Comment 3 2015-08-12 19:02:25 PDT
Comment on attachment 258873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258873&action=review > Source/WebCore/platform/graphics/FontPlatformData.h:140 > + bool isForTextCombine() const { return widthVariant() != RegularWidth; } // Keep in sync with callers of FontDescription::setWidthVariant() Nit: missing punctuation. > LayoutTests/ChangeLog:10 > + * fast/text/system-font-punctuation.html: Added. I think you are missing results.
Myles C. Maxfield
Comment 4 2015-08-12 22:36:46 PDT
Committed r188377: <http://trac.webkit.org/changeset/188377>
Myles C. Maxfield
Comment 5 2015-08-12 22:37:34 PDT
<rdar://problem/22256660>
Alexey Proskuryakov
Comment 6 2015-08-13 08:47:54 PDT
Comment on attachment 258873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258873&action=review >> LayoutTests/ChangeLog:10 >> + * fast/text/system-font-punctuation.html: Added. > > I think you are missing results. Still missing results in the landed patch. ChangeLog says that they are there, but Mac results aren't.
Alexey Proskuryakov
Comment 7 2015-08-13 08:54:46 PDT
Looks like the results are the same for all OS X versions; landed in r188383.
Myles C. Maxfield
Comment 8 2015-08-13 09:06:51 PDT
Thanks Alexey.
Enrica Casucci
Comment 9 2015-08-13 13:41:25 PDT
Comment on attachment 258873 [details] Patch The patch sounds very reasonable to me.
Note You need to log in before you can comment on or make changes to this bug.