Bug 147960

Summary:

Web Inspector: Hide child rows for filtered tasks in the Rendering Frames data grid

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Current UI, with layout filtered	none
[Patch] Proposed Fix	none
[Patch] Proposed Fix	none

Description Matt Baker 2015-08-12 17:30:32 PDT

* SUMMARY
Hide child rows for filtered tasks in the Rendering Frames data grid. Currently we only hide Frame rows, and only when all child records are for tasks which have been filtered.

* STEPS TO REPRODUCE
1. Record a timeline with a mixture of script, layout, etc (recording daring fireball.net page load is sufficient)
2. Uncheck Layout
3. Expand a Frame containing layout and other tasks
  => Layout records are still visible

Comment 1 Matt Baker 2015-08-12 17:31:31 PDT

Created attachment 258858 [details]
[Image] Current UI, with layout filtered

Comment 2 Matt Baker 2015-08-12 17:46:18 PDT

Created attachment 258862 [details]
[Patch] Proposed Fix

Comment 3 WebKit Commit Bot 2015-08-12 19:13:45 PDT

Comment on attachment 258862 [details]
[Patch] Proposed Fix

Rejecting attachment 258862 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 258862, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
from patch file(s).
patching file Source/WebInspectorUI/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/ChangeLog.rej
patching file Source/WebInspectorUI/UserInterface/Models/RenderingFrameTimelineRecord.js
patching file Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/51188

Comment 4 Matt Baker 2015-08-13 12:08:28 PDT

Created attachment 258911 [details]
[Patch] Proposed Fix

Comment 5 WebKit Commit Bot 2015-08-13 13:29:42 PDT

Comment on attachment 258911 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 258911

Committed r188398: <http://trac.webkit.org/changeset/188398>

Comment 6 WebKit Commit Bot 2015-08-13 13:29:47 PDT

All reviewed patches have been landed.  Closing bug.