Bug 147919

Summary: Web Inspector: Implement selector highlighting for iOS
Product: WebKit Reporter: Devin Rousso <drousso>
Component: Web InspectorAssignee: Devin Rousso <drousso>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
timothy: review+
Patch none

Description Devin Rousso 2015-08-11 19:28:36 PDT
Originally from https://bugs.webkit.org/show_bug.cgi?id=145658.  Basically, this would allow a node list to be passed to the highlight view which would render overlays on multiple nodes instead of just one.
Comment 1 Devin Rousso 2015-08-11 19:34:52 PDT
Created attachment 258794 [details]
Patch
Comment 2 Timothy Hatcher 2015-08-11 21:59:26 PDT
Comment on attachment 258794 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258794&action=review

> Source/WebKit2/UIProcess/WKInspectorHighlightView.mm:219
> +    if ([_layers count] < (offset + 4) || highlight.quads.size() < (offset + 4))

No need for the () around the math.

> Source/WebKit2/UIProcess/WKInspectorHighlightView.mm:251
> +    [self _createLayers:(nodeCount * 4)];

Ditto. Line break after this line before the loop.

> Source/WebKit2/UIProcess/WKInspectorHighlightView.mm:253
> +        [self _layoutForNodeHighlight:highlight offset:(i * 4)];

No ().
Comment 3 Devin Rousso 2015-08-12 10:02:14 PDT
Created attachment 258825 [details]
Patch
Comment 4 WebKit Commit Bot 2015-08-12 10:22:17 PDT
Attachment 258825 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WKInspectorHighlightView.mm:219:  The parameter name "4" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2015-08-12 10:54:18 PDT
Comment on attachment 258825 [details]
Patch

Clearing flags on attachment: 258825

Committed r188337: <http://trac.webkit.org/changeset/188337>
Comment 6 WebKit Commit Bot 2015-08-12 10:54:21 PDT
All reviewed patches have been landed.  Closing bug.