Summary: | Web Inspector: Implement selector highlighting for iOS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Devin Rousso
2015-08-11 19:28:36 PDT
Created attachment 258794 [details]
Patch
Comment on attachment 258794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258794&action=review > Source/WebKit2/UIProcess/WKInspectorHighlightView.mm:219 > + if ([_layers count] < (offset + 4) || highlight.quads.size() < (offset + 4)) No need for the () around the math. > Source/WebKit2/UIProcess/WKInspectorHighlightView.mm:251 > + [self _createLayers:(nodeCount * 4)]; Ditto. Line break after this line before the loop. > Source/WebKit2/UIProcess/WKInspectorHighlightView.mm:253 > + [self _layoutForNodeHighlight:highlight offset:(i * 4)]; No (). Created attachment 258825 [details]
Patch
Attachment 258825 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/WKInspectorHighlightView.mm:219: The parameter name "4" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 258825 [details] Patch Clearing flags on attachment: 258825 Committed r188337: <http://trac.webkit.org/changeset/188337> All reviewed patches have been landed. Closing bug. |