Bug 147874 – [ES6] Implement Reflect.getPrototypeOf and Reflect.setPrototypeOf

• Component: New Bugs
• Status: RESOLVED FIXED

[Yusuke Suzuki]

[ES6] Implement Reflect.getPrototypeOf and Reflect.setPrototypeOf

[Yusuke Suzuki]

Created attachment 258711 [details]
Patch

[Darin Adler]

Comment on attachment 258711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258711&action=review

> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:190
>          return JSValue::encode(jsNull());

Strange that this uses jsNull where most call sites use jsUndefined, yet this value is always ignored. Untidy to have this be different across the code base.

[Yusuke Suzuki]

Comment on attachment 258711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258711&action=review

Thank you :)

>> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:190
>>          return JSValue::encode(jsNull());
> 
> Strange that this uses jsNull where most call sites use jsUndefined, yet this value is always ignored. Untidy to have this be different across the code base.

Seeing the ObjectConstructor.cpp, in this file, using "jsNull()" as the non meaningful return value for the exception is major.
So I'll fix the touched part in this patch: `objectConstructorGetPrototypeOf` one.
When modifying / fixing the other part, at that time, we need to fix it gradually.

[Yusuke Suzuki]

Committed r188262: <http://trac.webkit.org/changeset/188262>