Bug 147865 – [WebIDL] All interface objects must have a property named "name"

• Component: Bindings
• Status: RESOLVED FIXED

[Chris Dumez]

As per the Web IDL specification, all interface objects must have a property named "name" with attributes { [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: true } whose value is the identifier of the corresponding interface:
http://heycam.github.io/webidl/#es-interface-call

Currently, our interface objects have no such property.

Both Firefox 38 and Chrome 44 comply with the Web IDL specification here.

[Chris Dumez]

Created attachment 258699 [details]
Patch

[Chris Dumez]

Created attachment 258700 [details]
Patch

[Build Bot]

Comment on attachment 258700 [details]
Patch

Attachment 258700 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/43166

New failing tests:
media/track/track-cue-empty-cue-text.html

[Build Bot]

Created attachment 258703 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 258700 [details]
Patch

Attachment 258700 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/43160

New failing tests:
media/track/track-cue-empty-cue-text.html

[Build Bot]

Created attachment 258704 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Darin Adler]

Comment on attachment 258700 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258700&action=review

> Source/WebCore/ChangeLog:23
> +        * bindings/scripts/CodeGeneratorJS.pm:
> +        (GenerateConstructorHelperMethods):

Need to do:

    run-bindings-tests --reset-results

And include the change to expected results in the patch.

[Darin Adler]

Looks like that media/track/track-cue-empty-cue-text.html change is a real change, maybe a progression. So need to include expectations changes for that in the patch too.

[Chris Dumez]

(In reply to comment #8)
> Looks like that media/track/track-cue-empty-cue-text.html change is a real
> change, maybe a progression. So need to include expectations changes for
> that in the patch too.

Yes, it looks like a progression indeed:
 ** The document fragment should have one child, an empty Text node **
 EXPECTED (fragment.childNodes.length == '1') OK
 EXPECTED (fragment.childNodes[0].length == '0') OK
-EXPECTED (fragment.childNodes[0].constructor.name == 'undefined') OK
+EXPECTED (fragment.childNodes[0].constructor.name == 'Text') OK

I'll rebaseline this and the bindings tests before landing.

[Chris Dumez]

Created attachment 258721 [details]
Patch

[Chris Dumez]

Created attachment 258722 [details]
Patch

[Chris Dumez]

Comment on attachment 258722 [details]
Patch

Clearing flags on attachment: 258722

Committed r188258: <http://trac.webkit.org/changeset/188258>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.