Bug 147861

Summary: The 'prototype' property on interface objects should not be enumerable
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, ggaren, ossy, sam
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://heycam.github.io/webidl/#interface-object
Attachments:
Description Flags
Patch none

Description Chris Dumez 2015-08-10 19:18:17 PDT 
The 'prototype' property on interfaces objects should NOT be enumerable. Currently it is in WebKit.

Compatibility:
- Web IDL spec says the property should NOT be enumerable: http://heycam.github.io/webidl/#interface-object
- It is configurable in Firefox 38 and Chrome 44.

W3C test suite:
http://w3c-test.org/dom/interfaces.html
Comment 1 Chris Dumez 2015-08-10 19:30:20 PDT 
(In reply to comment #0)
> The 'prototype' property on interfaces objects should NOT be enumerable.
> Currently it is in WebKit.
> 
> Compatibility:
> - Web IDL spec says the property should NOT be enumerable:
> http://heycam.github.io/webidl/#interface-object
> - It is configurable in Firefox 38 and Chrome 44.

I meant it is *not enumerable* in Firefox 38 and Chrome 44.
Comment 2 Chris Dumez 2015-08-10 20:38:53 PDT 
Created attachment 258695 [details]
Patch
Comment 3 WebKit Commit Bot 2015-08-10 23:42:29 PDT 
Comment on attachment 258695 [details]
Patch

Clearing flags on attachment: 258695

Committed r188252: <http://trac.webkit.org/changeset/188252>
Comment 4 WebKit Commit Bot 2015-08-10 23:42:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2015-08-11 00:30:39 PDT 
(In reply to comment #3)
> Comment on attachment 258695 [details]
> Patch
> 
> Clearing flags on attachment: 258695
> 
> Committed r188252: <http://trac.webkit.org/changeset/188252>

It broke the bindings tests. Could you fix it?
Comment 6 Chris Dumez 2015-08-11 07:57:34 PDT 
(In reply to comment #5)
> (In reply to comment #3)
> > Comment on attachment 258695 [details]
> > Patch
> > 
> > Clearing flags on attachment: 258695
> > 
> > Committed r188252: <http://trac.webkit.org/changeset/188252>
> 
> It broke the bindings tests. Could you fix it?

Done in https://trac.webkit.org/r188254, thanks.