Summary: | Invalid FrameView::m_viewportRenderer after layout is finished. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, davidkclark, ddkilzer, simon.fraser | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
zalan
2015-08-10 15:37:16 PDT
Created attachment 258659 [details]
Patch
Need to construct a test case. Created attachment 258726 [details]
Patch
Comment on attachment 258726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258726&action=review > Source/WebCore/page/FrameView.cpp:624 > + if (!renderView || !viewportRenderer || !is<RenderBox>(viewportRenderer) || !frame().isMainFrame()) This: !viewportRenderer || !is<RenderBox>(viewportRenderer) Is the same as this: !is<RenderBox>(viewportRenderer) So I think we should remove the extra null check. (In reply to comment #5) > Comment on attachment 258726 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258726&action=review > > > Source/WebCore/page/FrameView.cpp:624 > > + if (!renderView || !viewportRenderer || !is<RenderBox>(viewportRenderer) || !frame().isMainFrame()) > > This: > > !viewportRenderer || !is<RenderBox>(viewportRenderer) > > Is the same as this: > > !is<RenderBox>(viewportRenderer) > > So I think we should remove the extra null check. Good point! Created attachment 258740 [details]
Patch
Comment on attachment 258740 [details] Patch Clearing flags on attachment: 258740 Committed r188298: <http://trac.webkit.org/changeset/188298> All reviewed patches have been landed. Closing bug. Comment on attachment 258740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258740&action=review > Source/WebCore/page/FrameView.cpp:758 > + auto documentElement = document->documentElement(); Shouldn't this be of type "auto*" as it is later in the patch? auto* documentElement = document->documentElement(); Comment on attachment 258740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258740&action=review >> Source/WebCore/page/FrameView.cpp:758 >> + auto documentElement = document->documentElement(); > > Shouldn't this be of type "auto*" as it is later in the patch? > > auto* documentElement = document->documentElement(); It should! I'll fix it in one of my upcoming patches. (note: it does not change functionality) *** Bug 149495 has been marked as a duplicate of this bug. *** |