Bug 147840

Summary: Make ASan build not depend on asan.xcconfig
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: JavaScriptCoreAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, dbates, ddkilzer, fpizlo, ggaren, mitz
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2015-08-10 13:49:38 PDT
Address Sanitizer can be enabled by forcing clang build flags from any build system, but we currently depend on injecting asan.xcconfig. rdar://problem/21093702
Attachments
proposed patch (11.11 KB, patch)
2015-08-10 13:57 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-08-10 13:57:13 PDT
Created attachment 258649 [details] proposed patch To be clear, we will still be using the xcconfig to enable ASan on Mac, however it won't be required. The patch is mechanical; it's possible that we don't need to use asanUnsafeJSValue() just as much.
Daniel Bates
Comment 2 2015-08-11 11:59:32 PDT
Comment on attachment 258649 [details] proposed patch OK.
Filip Pizlo
Comment 3 2015-08-11 15:40:03 PDT
Comment on attachment 258649 [details] proposed patch LGTM
WebKit Commit Bot
Comment 4 2015-08-11 16:50:22 PDT
Comment on attachment 258649 [details] proposed patch Clearing flags on attachment: 258649 Committed r188311: <http://trac.webkit.org/changeset/188311>
WebKit Commit Bot
Comment 5 2015-08-11 16:50:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.