Bug 147840

Summary: Make ASan build not depend on asan.xcconfig
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: JavaScriptCoreAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, dbates, ddkilzer, fpizlo, ggaren, mitz
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Description Alexey Proskuryakov 2015-08-10 13:49:38 PDT 
Address Sanitizer can be enabled by forcing clang build flags from any build system, but we currently depend on injecting asan.xcconfig.

rdar://problem/21093702
Comment 1 Alexey Proskuryakov 2015-08-10 13:57:13 PDT 
Created attachment 258649 [details]
proposed patch

To be clear, we will still be using the xcconfig to enable ASan on Mac, however it won't be required.

The patch is mechanical; it's possible that we don't need to use asanUnsafeJSValue() just as much.
Comment 2 Daniel Bates 2015-08-11 11:59:32 PDT 
Comment on attachment 258649 [details]
proposed patch

OK.
Comment 3 Filip Pizlo 2015-08-11 15:40:03 PDT 
Comment on attachment 258649 [details]
proposed patch

LGTM
Comment 4 WebKit Commit Bot 2015-08-11 16:50:22 PDT 
Comment on attachment 258649 [details]
proposed patch

Clearing flags on attachment: 258649

Committed r188311: <http://trac.webkit.org/changeset/188311>
Comment 5 WebKit Commit Bot 2015-08-11 16:50:26 PDT 
All reviewed patches have been landed.  Closing bug.