Bug 147820

Summary:

Rename Color to OptionalRGBA

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

New Bugs

Assignee:

Darin Adler <darin>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

commit-queue, ggaren

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ggaren: review-

Description Darin Adler 2015-08-09 19:32:03 PDT

Rename Color to OptionalRGBA

Comment 1 Darin Adler 2015-08-09 19:36:42 PDT

Created attachment 258607 [details]
Patch

Comment 2 WebKit Commit Bot 2015-08-09 19:40:31 PDT

Attachment 258607 [details] did not pass style-queue:


WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitColorChooser.h"
ERROR: Source/WebCore/platform/graphics/mac/ColorMac.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:175:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:180:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/rendering/RenderInline.cpp:1597:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderInline.h:177:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderThemeSafari.h:66:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderThemeMac.mm:629:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/Color.h:26:  #ifndef header guard has wrong style, please use: Color_h  [build/header_guard] [5]
ERROR: Source/WebCore/platform/graphics/Color.h:73:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/Color.h:75:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/Color.h:76:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/Color.h:78:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/Color.h:80:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/win/WebCoreTextRenderer.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/BitmapImage.h:319:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/win/DragDataWin.cpp:205:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebKit/win/WebView.cpp:5848:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:797:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:804:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderThemeSafari.cpp:232:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/Gradient.h:54:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:156:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:263:  Missing space before {  [whitespace/braces] [5]
Total errors found: 23 in 379 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Darin Adler 2015-08-09 19:47:03 PDT

Created attachment 258608 [details]
Patch

Comment 4 WebKit Commit Bot 2015-08-09 19:50:47 PDT

Attachment 258608 [details] did not pass style-queue:


WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitColorChooser.h"
ERROR: Source/WebCore/platform/graphics/mac/ColorMac.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:175:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:180:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/rendering/RenderInline.cpp:1597:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderInline.h:177:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderThemeSafari.h:66:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderThemeMac.mm:629:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/Color.h:73:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/Color.h:75:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/Color.h:76:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/Color.h:78:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/Color.h:80:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/win/WebCoreTextRenderer.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/BitmapImage.h:319:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/WebCore/platform/win/DragDataWin.cpp:205:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebKit/win/WebView.cpp:5848:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:797:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:804:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderThemeSafari.cpp:232:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/Gradient.h:54:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:156:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:263:  Missing space before {  [whitespace/braces] [5]
Total errors found: 22 in 379 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Geoffrey Garen 2015-08-11 15:51:31 PDT

/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/WebPageMessageReceiver.cpp:86:10: fatal error: 'WebCore/OptionalRGBA.h' file not found
#include <WebCore/OptionalRGBA.h>

Comment 6 Darin Adler 2015-08-17 18:14:52 PDT

I had a conversation about this with Beth, and after that talk I think I’m not going to do this. I’m going to chip at the problem from a different direction.