Bug 147817

Summary: AX: Address follow-up comments in bug 145684
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 145684    
Bug Blocks:    
Attachments:
Description Flags
patch none

James Craig
Reported 2015-08-09 14:28:28 PDT
AX: Address follow-up comments in bug 145684
Attachments
patch (4.63 KB, patch)
2015-08-09 16:59 PDT, James Craig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Craig
Comment 1 2015-08-09 14:30:42 PDT
>> LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt:18 >> + RenderButton {BUTTON} at (0,230) size 320x10 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)] > > It's weird that we still get a border even with appearance none. I wonder if we should be explicit about border: none !important? It doesn't really matter since the opacity is 0. I can address it in the follow up bug if you think it is better. >> LayoutTests/media/video-controls-show-on-kb-or-ax-event.html:32 >> + } > > No braces required here.
James Craig
Comment 2 2015-08-09 16:59:43 PDT
Created attachment 258601 [details] patch
WebKit Commit Bot
Comment 3 2015-08-10 09:01:38 PDT
Comment on attachment 258601 [details] patch Clearing flags on attachment: 258601 Committed r188213: <http://trac.webkit.org/changeset/188213>
WebKit Commit Bot
Comment 4 2015-08-10 09:01:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.