Summary: | Media Session: generalize isFocusedContentMediaElementPlaying so it works with other playback attributes | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Rajca <mrajca> | ||||||||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | conrad_shultz, eric.carlson, mrajca, webkit-bug-importer | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 145411 | ||||||||||||
Attachments: |
|
Description
Matt Rajca
2015-08-07 15:56:49 PDT
Created attachment 258538 [details]
Patch
Comment on attachment 258538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258538&action=review > Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h:35 > +#include <WebCore/MediaRemoteControls.h> I removed this include after sending out the patch since we don't need it here. Comment on attachment 258538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258538&action=review > Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h:66 > + HashMap<WKMediaSessionFocusManagerPlaybackAttribute, bool> m_playbackAttributes; Using a HashMap here is overkill, especially since you could put WKMediaSessionFocusManagerPlaybackAttribute into a bit mask. Created attachment 258625 [details]
Patch
(In reply to comment #3) > Comment on attachment 258538 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258538&action=review > > > Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h:66 > > + HashMap<WKMediaSessionFocusManagerPlaybackAttribute, bool> m_playbackAttributes; > > Using a HashMap here is overkill, especially since you could put > WKMediaSessionFocusManagerPlaybackAttribute into a bit mask. Switched over! Comment on attachment 258625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258625&action=review > Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h:44 > enum { > - IsPlaying = 1 << 0 > + IsPlaying = 1 << 0, > + IsPreviousTrackControlEnabled = 1 << 1, > + IsNextTrackControlEnabled = 1 << 2, > }; > typedef uint32_t WKMediaSessionFocusManagerPlaybackAttribute; This should be enum WKMediaSessionFocusManagerPlaybackAttribute { ... } typedef uint32_t WKMediaSessionFocusManagerPlaybackAttributes; > Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h:65 > + WKMediaSessionFocusManagerPlaybackAttribute m_playbackAttributes { 0 }; WKMediaSessionFocusManagerPlaybackAttributes Created attachment 258630 [details]
Patch
(In reply to comment #6) > Comment on attachment 258625 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258625&action=review > > > Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h:44 > > enum { > > - IsPlaying = 1 << 0 > > + IsPlaying = 1 << 0, > > + IsPreviousTrackControlEnabled = 1 << 1, > > + IsNextTrackControlEnabled = 1 << 2, > > }; > > typedef uint32_t WKMediaSessionFocusManagerPlaybackAttribute; > > This should be enum WKMediaSessionFocusManagerPlaybackAttribute { ... } > typedef uint32_t WKMediaSessionFocusManagerPlaybackAttributes; > > > Source/WebKit2/UIProcess/WebMediaSessionFocusManager.h:65 > > + WKMediaSessionFocusManagerPlaybackAttribute m_playbackAttributes { 0 }; > > WKMediaSessionFocusManagerPlaybackAttributes Fixed. Comment on attachment 258630 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258630&action=review > Source/WebKit2/UIProcess/API/C/WKMediaSessionFocusManager.h:65 > +WK_EXPORT bool WKMediaSessionFocusManagerValueForPlaybackAttribute(WKMediaSessionFocusManagerRef manager, WKMediaSessionFocusManagerPlaybackAttribute attribute); No need to name the parameters here. Created attachment 258633 [details]
Patch
Committed r188218: <http://trac.webkit.org/changeset/188218> |