Bug 147763

Summary:

AX: Bug 147737 is causing test failures in Mavericks WK1

Product:

WebKit

Reporter:

Doug Russell <d_russell>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, mmaxfield, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Doug Russell

Reported 2015-08-06 19:47:28 PDT

Some layout tests are failing in Mavericks WK1

Attachments
Patch (2.74 KB, patch) 2015-08-06 20:35 PDT, Doug Russell	no flags	Details Formatted Diff Diff
Patch (2.76 KB, patch) 2015-08-07 00:33 PDT, Doug Russell	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2015-08-06 20:18:22 PDT

This has been making our bots red for many revisions. Should we roll out the problem?

Doug Russell

Comment 2 2015-08-06 20:24:20 PDT

(In reply to comment #1) > This has been making our bots red for many revisions. Should we roll out the > problem? The change that led to this is only critical for El Cap+ so I have a patch that skips the test in Yosemite and Mavericks and a wraps the change in a 10.11+ macro. I'd rather have a fix that makes it work on Mavericks, but I think that will take longer and if you'd like this fixed now I can submit the patch I have right now.

Doug Russell

Comment 3 2015-08-06 20:35:21 PDT

Created attachment 258442 [details] Patch

Myles C. Maxfield

Comment 4 2015-08-06 22:47:11 PDT

Comment on attachment 258442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258442&action=review r=me to get the dashboard green > Source/WebCore/accessibility/AXObjectCache.cpp:132 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 This macro is only defined if PLATFORM(MAC) > LayoutTests/platform/mac/TestExpectations:1310 > +webkit.org/b/147763 [ Mavericks ] accessibility/mac/loaded-notification.html [ Skip ] There should be no need to skip these tests with the #if guard above

chris fleizach

Comment 5 2015-08-07 00:05:03 PDT

looks like iOS build failed to build for real here The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release-iphoneos/WebCore.build/Objects-normal/armv7/AXObjectCache.o accessibility/AXObjectCache.cpp normal armv7 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Fa

Doug Russell

Comment 6 2015-08-07 00:33:40 PDT

Created attachment 258466 [details] Patch

WebKit Commit Bot

Comment 7 2015-08-07 01:32:37 PDT

Comment on attachment 258466 [details] Patch Clearing flags on attachment: 258466 Committed r188120: <http://trac.webkit.org/changeset/188120>

WebKit Commit Bot

Comment 8 2015-08-07 01:32:41 PDT

All reviewed patches have been landed. Closing bug.

Myles C. Maxfield

Comment 9 2015-12-07 16:04:56 PST

Removing Mavericks-specific lines from platform/mac/TestExpecations due to no longer supporting Mavericks.