| Summary: | Move concrete KeyedDecoder/Encoder implementations to WebCore | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||
| Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Brady Eidson
2015-08-06 17:03:42 PDT
Created attachment 258453 [details]
Patch v1 - EWS to tell me what platforms break.
Attachment 258453 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/glib/KeyedDecoderGlib.h:26: #ifndef header guard has wrong style, please use: KeyedDecoderGlib_h [build/header_guard] [5]
ERROR: Source/WebCore/platform/cf/KeyedDecoderCF.h:26: #ifndef header guard has wrong style, please use: KeyedDecoderCF_h [build/header_guard] [5]
ERROR: Source/WebCore/platform/cf/KeyedEncoderCF.h:26: #ifndef header guard has wrong style, please use: KeyedEncoderCF_h [build/header_guard] [5]
ERROR: Source/WebCore/platform/glib/KeyedEncoderGlib.h:26: #ifndef header guard has wrong style, please use: KeyedEncoderGlib_h [build/header_guard] [5]
Total errors found: 4 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 258453 [details] did not pass style-queue: > > > ERROR: Source/WebCore/platform/glib/KeyedDecoderGlib.h:26: #ifndef header > guard has wrong style, please use: KeyedDecoderGlib_h [build/header_guard] > [5] > ERROR: Source/WebCore/platform/cf/KeyedDecoderCF.h:26: #ifndef header guard > has wrong style, please use: KeyedDecoderCF_h [build/header_guard] [5] > ERROR: Source/WebCore/platform/cf/KeyedEncoderCF.h:26: #ifndef header guard > has wrong style, please use: KeyedEncoderCF_h [build/header_guard] [5] > ERROR: Source/WebCore/platform/glib/KeyedEncoderGlib.h:26: #ifndef header > guard has wrong style, please use: KeyedEncoderGlib_h [build/header_guard] > [5] > Total errors found: 4 in 11 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Indeed. Fixed locally. Created attachment 258455 [details]
Patch v2 for EWS
Attachment 258455 [details] did not pass style-queue:
ERROR: Source/WebCore/PlatformGTK.cmake:70: No trailing spaces [whitespace/trailing] [5]
ERROR: Source/WebCore/PlatformEfl.cmake:111: No trailing spaces [whitespace/trailing] [5]
Total errors found: 2 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #5) > Attachment 258455 [details] did not pass style-queue: > > > ERROR: Source/WebCore/PlatformGTK.cmake:70: No trailing spaces > [whitespace/trailing] [5] > ERROR: Source/WebCore/PlatformEfl.cmake:111: No trailing spaces > [whitespace/trailing] [5] > Total errors found: 2 in 13 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Will fix with a final patch Created attachment 258503 [details]
Patch v3 - For review/landing
Attachment 258503 [details] did not pass style-queue:
ERROR: Source/WebCore/PlatformGTK.cmake:70: No trailing spaces [whitespace/trailing] [5]
ERROR: Source/WebCore/PlatformEfl.cmake:111: No trailing spaces [whitespace/trailing] [5]
Total errors found: 2 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 258504 [details]
Patch v4 - For review and landing
Comment on attachment 258504 [details]
Patch v4 - For review and landing
rs=me
|