Bug 147757

Summary:

Move concrete KeyedDecoder/Encoder implementations to WebCore

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1 - EWS to tell me what platforms break.	none
Patch v2 for EWS	none
Patch v3 - For review/landing	none
Patch v4 - For review and landing	aestes: review+

Brady Eidson

Reported 2015-08-06 17:03:42 PDT

Move concrete KeyedDecoder/Encoder implementations to WebCore They'll be needed there for some feature work I'm doing, and there's no particular benefit to having them in WK2

Attachments
Patch v1 - EWS to tell me what platforms break. (87.34 KB, patch) 2015-08-06 21:53 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch v2 for EWS (89.41 KB, patch) 2015-08-06 22:29 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch v3 - For review/landing (95.48 KB, patch) 2015-08-07 08:26 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch v4 - For review and landing (95.47 KB, patch) 2015-08-07 08:31 PDT, Brady Eidson	aestes: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2015-08-06 21:53:00 PDT

Created attachment 258453 [details] Patch v1 - EWS to tell me what platforms break.

WebKit Commit Bot

Comment 2 2015-08-06 21:54:12 PDT

Attachment 258453 [details] did not pass style-queue: ERROR: Source/WebCore/platform/glib/KeyedDecoderGlib.h:26: #ifndef header guard has wrong style, please use: KeyedDecoderGlib_h [build/header_guard] [5] ERROR: Source/WebCore/platform/cf/KeyedDecoderCF.h:26: #ifndef header guard has wrong style, please use: KeyedDecoderCF_h [build/header_guard] [5] ERROR: Source/WebCore/platform/cf/KeyedEncoderCF.h:26: #ifndef header guard has wrong style, please use: KeyedEncoderCF_h [build/header_guard] [5] ERROR: Source/WebCore/platform/glib/KeyedEncoderGlib.h:26: #ifndef header guard has wrong style, please use: KeyedEncoderGlib_h [build/header_guard] [5] Total errors found: 4 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 3 2015-08-06 21:57:35 PDT

(In reply to comment #2) > Attachment 258453 [details] did not pass style-queue: > > > ERROR: Source/WebCore/platform/glib/KeyedDecoderGlib.h:26: #ifndef header > guard has wrong style, please use: KeyedDecoderGlib_h [build/header_guard] > [5] > ERROR: Source/WebCore/platform/cf/KeyedDecoderCF.h:26: #ifndef header guard > has wrong style, please use: KeyedDecoderCF_h [build/header_guard] [5] > ERROR: Source/WebCore/platform/cf/KeyedEncoderCF.h:26: #ifndef header guard > has wrong style, please use: KeyedEncoderCF_h [build/header_guard] [5] > ERROR: Source/WebCore/platform/glib/KeyedEncoderGlib.h:26: #ifndef header > guard has wrong style, please use: KeyedEncoderGlib_h [build/header_guard] > [5] > Total errors found: 4 in 11 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Indeed. Fixed locally.

Brady Eidson

Comment 4 2015-08-06 22:29:33 PDT

Created attachment 258455 [details] Patch v2 for EWS

WebKit Commit Bot

Comment 5 2015-08-06 22:32:07 PDT

Attachment 258455 [details] did not pass style-queue: ERROR: Source/WebCore/PlatformGTK.cmake:70: No trailing spaces [whitespace/trailing] [5] ERROR: Source/WebCore/PlatformEfl.cmake:111: No trailing spaces [whitespace/trailing] [5] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 6 2015-08-06 22:35:42 PDT

(In reply to comment #5) > Attachment 258455 [details] did not pass style-queue: > > > ERROR: Source/WebCore/PlatformGTK.cmake:70: No trailing spaces > [whitespace/trailing] [5] > ERROR: Source/WebCore/PlatformEfl.cmake:111: No trailing spaces > [whitespace/trailing] [5] > Total errors found: 2 in 13 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Will fix with a final patch

Brady Eidson

Comment 7 2015-08-07 08:26:16 PDT

Created attachment 258503 [details] Patch v3 - For review/landing

WebKit Commit Bot

Comment 8 2015-08-07 08:29:13 PDT

Attachment 258503 [details] did not pass style-queue: ERROR: Source/WebCore/PlatformGTK.cmake:70: No trailing spaces [whitespace/trailing] [5] ERROR: Source/WebCore/PlatformEfl.cmake:111: No trailing spaces [whitespace/trailing] [5] Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 9 2015-08-07 08:31:53 PDT

Created attachment 258504 [details] Patch v4 - For review and landing

Andy Estes

Comment 10 2015-08-07 08:43:08 PDT

Comment on attachment 258504 [details] Patch v4 - For review and landing rs=me

Brady Eidson

Comment 11 2015-08-07 09:05:21 PDT

https://trac.webkit.org/changeset/188126

Note You need to log in before you can comment on or make changes to this bug.