Summary: | http_server_driver and benchmark_builder should not be in run-benchmark's plan files | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||
Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, dewei_zhu, kling, slewis | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2015-08-06 15:59:23 PDT
Created attachment 258413 [details]
Cleanup
Created attachment 258416 [details]
Cleanup
Created attachment 258417 [details]
Cleanup
Comment on attachment 258417 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=258417&action=review rs=me with comment > Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:20 > builder_name = 'GenericBenchmarkBuilder' Forgot to update the name. (In reply to comment #4) > Comment on attachment 258417 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=258417&action=review > > rs=me with comment > > > Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:20 > > builder_name = 'GenericBenchmarkBuilder' > > Forgot to update the name. Oh right, we don't even need this because we no longer use factory. Committed r188092: <http://trac.webkit.org/changeset/188092> |