Bug 147752

Summary: http_server_driver and benchmark_builder should not be in run-benchmark's plan files
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, kling, slewis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Cleanup
none
Cleanup cdumez: review+

Description Ryosuke Niwa 2015-08-06 15:59:23 PDT
Simplify the plan files further
Comment 1 Ryosuke Niwa 2015-08-06 16:06:19 PDT
Created attachment 258413 [details]
Cleanup
Comment 2 Ryosuke Niwa 2015-08-06 16:11:35 PDT
Created attachment 258416 [details]
Cleanup
Comment 3 Ryosuke Niwa 2015-08-06 16:13:40 PDT
Created attachment 258417 [details]
Cleanup
Comment 4 Chris Dumez 2015-08-06 16:18:01 PDT
Comment on attachment 258417 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=258417&action=review

rs=me with comment

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:20
>      builder_name = 'GenericBenchmarkBuilder'

Forgot to update the name.
Comment 5 Ryosuke Niwa 2015-08-06 16:40:40 PDT
(In reply to comment #4)
> Comment on attachment 258417 [details]
> Cleanup
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258417&action=review
> 
> rs=me with comment
> 
> > Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:20
> >      builder_name = 'GenericBenchmarkBuilder'
> 
> Forgot to update the name.

Oh right, we don't even need this because we no longer use factory.
Comment 6 Ryosuke Niwa 2015-08-06 16:41:01 PDT
Committed r188092: <http://trac.webkit.org/changeset/188092>