Bug 147734

Summary:

Do not enforce "content-disposition: attachment" sandbox restrictions on a MediaDocument

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, kangil.han

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	aestes: review+

Description Eric Carlson 2015-08-06 11:18:32 PDT

Do not enforce "content-disposition: attachment" sandbox restrictions on a MediaDocument. A MediaDocument can't come with scripts, but we need to be able to run script in the shadow DOM for the controls to function.

Comment 1 Eric Carlson 2015-08-06 11:21:36 PDT

A layout test is proving difficult, filed bug 147735 for that.

Comment 2 Eric Carlson 2015-08-06 11:28:50 PDT

rdar://problem/22028179

Comment 3 Eric Carlson 2015-08-06 11:29:16 PDT

Created attachment 258379 [details]
Proposed patch

Comment 4 WebKit Commit Bot 2015-08-06 11:45:16 PDT

Comment on attachment 258379 [details]
Proposed patch

Clearing flags on attachment: 258379

Committed r188051: <http://trac.webkit.org/changeset/188051>

Comment 5 WebKit Commit Bot 2015-08-06 11:45:19 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Eric Carlson 2015-08-06 14:08:25 PDT

Re-opening, the initial fix was not quite right.

Comment 7 Eric Carlson 2015-08-06 14:09:06 PDT

Created attachment 258395 [details]
Proposed patch

Comment 8 Eric Carlson 2015-08-06 14:37:07 PDT

Committed r188062: https://trac.webkit.org/r188062