Bug 147734

Summary: Do not enforce "content-disposition: attachment" sandbox restrictions on a MediaDocument
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Proposed patch aestes: review+

Eric Carlson
Reported 2015-08-06 11:18:32 PDT
Do not enforce "content-disposition: attachment" sandbox restrictions on a MediaDocument. A MediaDocument can't come with scripts, but we need to be able to run script in the shadow DOM for the controls to function.
Attachments
Proposed patch (1.50 KB, patch)
2015-08-06 11:29 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Proposed patch (3.19 KB, patch)
2015-08-06 14:09 PDT, Eric Carlson 		aestes: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2015-08-06 11:21:36 PDT
A layout test is proving difficult, filed bug 147735 for that.
Eric Carlson
Comment 2 2015-08-06 11:28:50 PDT
rdar://problem/22028179
Eric Carlson
Comment 3 2015-08-06 11:29:16 PDT
Created attachment 258379 [details] Proposed patch
WebKit Commit Bot
Comment 4 2015-08-06 11:45:16 PDT
Comment on attachment 258379 [details] Proposed patch Clearing flags on attachment: 258379 Committed r188051: <http://trac.webkit.org/changeset/188051>
WebKit Commit Bot
Comment 5 2015-08-06 11:45:19 PDT
All reviewed patches have been landed. Closing bug.
Eric Carlson
Comment 6 2015-08-06 14:08:25 PDT
Re-opening, the initial fix was not quite right.
Eric Carlson
Comment 7 2015-08-06 14:09:06 PDT
Created attachment 258395 [details] Proposed patch
Eric Carlson
Comment 8 2015-08-06 14:37:07 PDT
Committed r188062: https://trac.webkit.org/r188062
Note You need to log in before you can comment on or make changes to this bug.