Bug 147725

Summary:

[EFL] Use the non-overlay scrollbar

Product:

WebKit

Reporter:

Hunseop Jeong <hs85.jeong>

Component:

WebKit EFL

Assignee:

Hunseop Jeong <hs85.jeong>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gyuyoung.kim, lucas.de.marchi, ryuan.choi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

140243

Bug Blocks:

148701, 148735

Attachments:

Description	Flags
Patch	none
Patch	none

Description Hunseop Jeong 2015-08-06 00:13:54 PDT

I think non-overlay scrollbar looks better than the overlay scrollbar and other ports do that.
But I turned on the overlay scrollbar to draw the scrollbar when I uploaded the patch(http://trac.webkit.org/changeset/186829).
Because non-overlay scrollbar has a problem(https://bugs.webkit.org/show_bug.cgi?id=140243).
If /b/140243 is fixed, we can show the non-overlay scrollbar with this patch.

Comment 1 Hunseop Jeong 2015-08-06 00:35:11 PDT

Created attachment 258358 [details]
Patch

Comment 2 Ryuan Choi 2015-08-06 00:37:23 PDT

(In reply to comment #0)
> I think non-overlay scrollbar looks better than the overlay scrollbar and
> other ports do that.
> But I turned on the overlay scrollbar to draw the scrollbar when I uploaded
> the patch(http://trac.webkit.org/changeset/186829).
> Because non-overlay scrollbar has a
> problem(https://bugs.webkit.org/show_bug.cgi?id=140243).
> If /b/140243 is fixed, we can show the non-overlay scrollbar with this patch.

I think that it should be an optional via theme.

Comment 3 Hunseop Jeong 2015-08-06 01:02:23 PDT

Created attachment 258359 [details]
Patch

Comment 4 Hunseop Jeong 2015-08-06 01:08:44 PDT

(In reply to comment #2)
> (In reply to comment #0)
> > I think non-overlay scrollbar looks better than the overlay scrollbar and
> > other ports do that.
> > But I turned on the overlay scrollbar to draw the scrollbar when I uploaded
> > the patch(http://trac.webkit.org/changeset/186829).
> > Because non-overlay scrollbar has a
> > problem(https://bugs.webkit.org/show_bug.cgi?id=140243).
> > If /b/140243 is fixed, we can show the non-overlay scrollbar with this patch.
> 
> I think that it should be an optional via theme.

I changed the condition to use the setting value.

Comment 5 WebKit Commit Bot 2015-08-09 23:51:16 PDT

Comment on attachment 258359 [details]
Patch

Clearing flags on attachment: 258359

Committed r188206: <http://trac.webkit.org/changeset/188206>

Comment 6 WebKit Commit Bot 2015-08-09 23:51:21 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Gyuyoung Kim 2015-09-01 19:36:17 PDT

(In reply to comment #5)
> Comment on attachment 258359 [details]
> Patch
> 
> Clearing flags on attachment: 258359
> 
> Committed r188206: <http://trac.webkit.org/changeset/188206>


EFL API test has been broken since r188206.

ERR<5605>:ecore_evas modules/ecore_evas/engines/x/ecore_evas_x.c:4493 ecore_evas_gl_x11_options_new_internal() evas_engine_info_set() init engine 'opengl_x11' failed.
ERR<5605>:evas_main lib/evas/canvas/evas_gl.c:138 evas_gl_new() Evas GL engine not available.
ERR<5605>: ../../Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:54 toEwkViewChecked() safety check failed: evasObject == NULL
CRI<5605>: ../../Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:767 ewk_view_contents_size_get() no private data for object (nil)
../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1208: Failure
Value of: contentsWidth
  Actual: 790
Expected: environment->defaultWidth()
Which is: 800