Summary: | [GTK] Fix build issue related to the generated WebKitFontFamilyNames.h | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, calvaris, cgarcia, clopez, commit-queue, mrobinson, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2015-08-05 22:54:09 PDT
First time we can noticed this clean build failure: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/61040, because the build #61039 caused a fresh SVN checkout. One more thing: It's strange that EFL doesn't have this build problem, but this codes are in common cmake code path as far as I know. +info: I checked the generated ninja file of GTK and EFL too and it seems that testing/MockCDM.cpp is the only one source file which has the WebKitFontFamilyNames.h dependency set on EFL. But no other cpp has set this dependency. Maybe because they are added to WebCoreTestSupport_SOURCES and not to WebCore_SOURCES variable. Looking at the log, it seems to me that r187997 could have introduced the issue, since it removes the WebCore dependency from a couple of targets. (In reply to comment #4) > Looking at the log, it seems to me that r187997 could have introduced the > issue, since it removes the WebCore dependency from a couple of targets. It is definitely this revision, I bisected it. Created attachment 258394 [details]
Patch
Sorry! Brent even commented about that line in WebCore/CMakeLists.txt. I guess EWS doesn't do clean builds, which is where this problem arises. My bad. Does this patch fix it? Also, is it really necessary to have a dependency on ${WEBCORE_DIR}/CMakeLists.txt inside of CMakeLists.txt? It would save a lot of rebuilding time if that weren't there, but I'm not sure why it's there enough to remove it. This seems to prevent me from running into the same issue on the partially-complete CMake build on mac. Comment on attachment 258394 [details]
Patch
EFL port also has same build error when building it from scratch.
Comment on attachment 258394 [details] Patch Clearing flags on attachment: 258394 Committed r188116: <http://trac.webkit.org/changeset/188116> All reviewed patches have been landed. Closing bug. |