| Summary: | Rename Mutex to DeprecatedMutex | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
| Component: | Web Template Framework | Assignee: | Filip Pizlo <fpizlo> | ||||||||
| Status: | RESOLVED WONTFIX | ||||||||||
| Severity: | Normal | CC: | andersca, barraclough, commit-queue, ggaren | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 147545 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Filip Pizlo
2015-08-04 18:47:41 PDT
Created attachment 258256 [details]
it's a start
Created attachment 258261 [details]
the patch
Created attachment 258263 [details]
the patch
Attachment 258263 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:136: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WTF/wtf/ThreadingPrimitives.h:97: The parameter name "mutex" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 130 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 258263 [details]
the patch
r=me
It's arguably premature to do this before we've proven that the new mutex is, in fact, better -- but I'll take a small gamble here.
> ERROR: Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:136:
> Place brace on its own line for function definitions. [whitespace/braces]
> [4]
> ERROR: Source/WTF/wtf/ThreadingPrimitives.h:97: The parameter name "mutex"
> adds no information, so it should be removed. [readability/parameter_name]
> [5]
These are worth fixing, since we're here.
(In reply to comment #5) > Comment on attachment 258263 [details] > the patch > > r=me > > It's arguably premature to do this before we've proven that the new mutex > is, in fact, better -- but I'll take a small gamble here. Even if it isn't better, we should be using std::mutex in favor of WTF::(Deprecated)Mutex. Landed in http://trac.webkit.org/changeset/187972 Rolled out in http://trac.webkit.org/changeset/188002 |