Bug 14766

Summary:

S60 browser finditem should be able to find VoIP address

Product:

WebKit

Reporter:

George Guo <george.guo>

Component:

WebKit Misc.

Assignee:

George Guo <george.guo>

Status:

CLOSED INVALID

Severity:

Normal

CC:

george.guo

Priority:

Version:

523.x (Safari 3)

Hardware:

S60 Hardware

OS:

S60 3rd edition

Attachments:

Description	Flags
patch for the solution	Sachin.Padma: review-
New patch	none
patch without ifdef	Sachin.Padma: review-
New patch	none
CR is in defined status, new patch needed	Sachin.Padma: review-
New patch after changes based on the previous review	none

George Guo

Reported 2007-07-25 15:07:53 PDT

According to Find Item UI spec, browser finditem structure should be as follows: Phone number VoIP address E-mail address URL address Browser overrides initialization of Find submenu and does not add option for VoIP address there. Refer to JPKN-6X98ZB

Attachments
patch for the solution (19.07 KB, patch) 2007-07-26 07:51 PDT, George Guo	Sachin.Padma: review-	Details Formatted Diff Diff
New patch (18.21 KB, patch) 2007-07-30 06:35 PDT, George Guo	no flags	Details Formatted Diff Diff
patch without ifdef (17.25 KB, patch) 2007-07-30 14:54 PDT, George Guo	Sachin.Padma: review-	Details Formatted Diff Diff
New patch (20.74 KB, patch) 2007-07-31 14:49 PDT, George Guo	no flags	Details Formatted Diff Diff
CR is in defined status, new patch needed (19.95 KB, patch) 2007-08-14 09:05 PDT, George Guo	Sachin.Padma: review-	Details Formatted Diff Diff
New patch after changes based on the previous review (15.25 KB, patch) 2007-09-06 13:43 PDT, George Guo	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

George Guo

Comment 1 2007-07-26 07:51:31 PDT

Created attachment 15691 [details] patch for the solution

Sachin Padma

Comment 2 2007-07-27 08:13:26 PDT

Comment on attachment 15691 [details] patch for the solution Please check the ifdef flags. They are not placed correctly

George Guo

Comment 3 2007-07-30 06:35:40 PDT

Created attachment 15743 [details] New patch

George Guo

Comment 4 2007-07-30 14:54:04 PDT

Created attachment 15751 [details] patch without ifdef

Sachin Padma

Comment 5 2007-07-31 14:01:00 PDT

Comment on attachment 15751 [details] patch without ifdef in normal scrolling mode numbers should be found. Please check formatting.

George Guo

Comment 6 2007-07-31 14:49:51 PDT

Created attachment 15765 [details] New patch Did the test the scrolling is still working well. Scrolling is using CheckSmartTextEntry and FindItem is using FindNextSmartLink. They won't interfere each other. Fixed some historical format issues in WebKitView.cpp as well. Please review.

George Guo

Comment 7 2007-08-14 09:05:32 PDT

Created attachment 15960 [details] CR is in defined status, new patch needed CR 409-415 is in defined status. Patch needed

Sachin Padma

Comment 8 2007-08-27 14:05:08 PDT

Comment on attachment 15960 [details] CR is in defined status, new patch needed voip call command is not in browser control commands. Check formatting issues. There are two if statements in webkitcursor.cpp that can be combined when assigning cursor image.

George Guo

Comment 9 2007-09-06 13:43:57 PDT

Created attachment 16210 [details] New patch after changes based on the previous review The following changes were made: (1) Voip call command was enabled (2) Two if statements were combined in webkitcursor.cpp (3) Format were checked. Furthermore the belowing is the test results * Find phone number still work pass * Find Keyword still work pass * Find Email address still work pass * Find IP address can find email and phone pass * Find VoIP can find 3 digits from 123ok pass * Find VoIP can go back to the beginning at the end pass * Turn on the smart text recoginition work pass * After text recogniztion on, do the above tests pass voip call command is not in browser control commands. Check formatting issues. There are two if statements in webkitcursor.cpp that can be combined when assigning cursor image.

Bradley Morrison

Comment 10 2008-04-09 11:31:48 PDT

Bulk update of s60 bugs - tagging and closing.

Bradley Morrison

Comment 11 2008-04-09 11:39:10 PDT

Bulk closing of all s60 platform bugs. Sorry for the noise!

Bradley Morrison

Comment 12 2008-04-09 11:39:24 PDT

Bulk closing of all s60 platform bugs. Sorry for the noise!

Joel Parks

Comment 13 2011-03-21 11:53:35 PDT

re-purposing InTSW keyword for use by QtWebkit team

Note You need to log in before you can comment on or make changes to this bug.