Bug 14766

Summary: S60 browser finditem should be able to find VoIP address
Product: WebKit Reporter: George Guo <george.guo>
Component: WebKit Misc.Assignee: George Guo <george.guo>
Status: CLOSED INVALID    
Severity: Normal CC: george.guo
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Attachments:
Description Flags
patch for the solution
Sachin.Padma: review-
New patch
none
patch without ifdef
Sachin.Padma: review-
New patch
none
CR is in defined status, new patch needed
Sachin.Padma: review-
New patch after changes based on the previous review none

Description George Guo 2007-07-25 15:07:53 PDT
According to Find Item UI spec, browser finditem structure should be as follows:
		Phone number
		VoIP address
		E-mail address
		URL address

Browser overrides initialization of Find submenu and does not add option for VoIP address there. 

Refer to JPKN-6X98ZB
Comment 1 George Guo 2007-07-26 07:51:31 PDT
Created attachment 15691 [details]
patch for the solution
Comment 2 Sachin Padma 2007-07-27 08:13:26 PDT
Comment on attachment 15691 [details]
patch for the solution

Please check the ifdef flags. They are not placed correctly
Comment 3 George Guo 2007-07-30 06:35:40 PDT
Created attachment 15743 [details]
New patch
Comment 4 George Guo 2007-07-30 14:54:04 PDT
Created attachment 15751 [details]
patch without ifdef
Comment 5 Sachin Padma 2007-07-31 14:01:00 PDT
Comment on attachment 15751 [details]
patch without ifdef 

in normal scrolling mode numbers should be found. Please check formatting.
Comment 6 George Guo 2007-07-31 14:49:51 PDT
Created attachment 15765 [details]
New patch 

Did the test the scrolling is still working well. Scrolling is using CheckSmartTextEntry and FindItem is using FindNextSmartLink. They won't interfere each other. 

Fixed some historical format issues in WebKitView.cpp as well.

Please review.
Comment 7 George Guo 2007-08-14 09:05:32 PDT
Created attachment 15960 [details]
CR is in defined status, new patch needed

CR 409-415 is in defined status. Patch needed
Comment 8 Sachin Padma 2007-08-27 14:05:08 PDT
Comment on attachment 15960 [details]
CR is in defined status, new patch needed

voip call command is not in browser control commands. Check formatting issues. There are two if statements in webkitcursor.cpp that can be combined when assigning cursor image.
Comment 9 George Guo 2007-09-06 13:43:57 PDT
Created attachment 16210 [details]
New patch after changes based on the previous review

The following changes were made: 
(1) Voip call command was enabled
(2) Two if statements were combined in webkitcursor.cpp 
(3) Format were checked. 
Furthermore the belowing is the test results
* Find phone number still work				pass
* Find Keyword still work				pass
* Find Email address still work 			pass
* Find IP address can find email and phone		pass
* Find VoIP can find 3 digits from 123ok		pass 
* Find VoIP can go back to the beginning at the end	pass 
* Turn on the smart text recoginition work		pass
* After text recogniztion on, do the above tests	pass 



voip call command is not in browser control commands. Check formatting issues.
There are two if statements in webkitcursor.cpp that can be combined when
assigning cursor image.
Comment 10 Bradley Morrison 2008-04-09 11:31:48 PDT
Bulk update of s60 bugs - tagging and closing.
Comment 11 Bradley Morrison 2008-04-09 11:39:10 PDT
Bulk closing of all s60 platform bugs. 

Sorry for the noise!
Comment 12 Bradley Morrison 2008-04-09 11:39:24 PDT
Bulk closing of all s60 platform bugs. 

Sorry for the noise!
Comment 13 Joel Parks 2011-03-21 11:53:35 PDT
re-purposing InTSW keyword for use by QtWebkit team