Bug 147643

Summary: Render to GraphicsContext MediaPlayerPrivateMediaStreamAVFObjC
Product: WebKit Reporter: Matthew Daiter <mdaiter>
Component: WebCore Misc.Assignee: Matthew Daiter <mdaiter>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, jeremyj-wk, jer.noble, jonlee, mdaiter, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Matthew Daiter
Reported 2015-08-04 12:00:37 PDT
Really, painting a MediaStream is just painting a MediaStream in a currentFrameInContext. So we feed in the parameters from paint() to paintCurrentFrameInContext().
Attachments
Patch (1.70 KB, patch)
2015-08-04 12:03 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Patch (1.69 KB, patch)
2015-08-04 12:59 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matthew Daiter
Comment 1 2015-08-04 12:03:25 PDT
Created attachment 258196 [details] Patch
Eric Carlson
Comment 2 2015-08-04 12:23:12 PDT
Comment on attachment 258196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258196&action=review > Source/WebCore/ChangeLog:3 > + Need to pipe paint() into paintCurrentFrameInContext() for MediaStream Please use the actual bug title.
WebKit Commit Bot
Comment 3 2015-08-04 12:27:21 PDT
Comment on attachment 258196 [details] Patch Rejecting attachment 258196 [details] from commit-queue. mdaiter@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Eric Carlson
Comment 4 2015-08-04 12:57:31 PDT
Comment on attachment 258196 [details] Patch Please update the title in the ChangeLog
Matthew Daiter
Comment 5 2015-08-04 12:59:40 PDT
Created attachment 258200 [details] Patch
Matthew Daiter
Comment 6 2015-08-04 13:00:00 PDT
Comment on attachment 258196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258196&action=review >> Source/WebCore/ChangeLog:3 >> + Need to pipe paint() into paintCurrentFrameInContext() for MediaStream > > Please use the actual bug title. Fixed.
WebKit Commit Bot
Comment 7 2015-08-04 13:24:30 PDT
Comment on attachment 258200 [details] Patch Rejecting attachment 258200 [details] from commit-queue. mdaiter@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 8 2015-08-04 13:39:18 PDT
Comment on attachment 258200 [details] Patch Clearing flags on attachment: 258200 Committed r187884: <http://trac.webkit.org/changeset/187884>
WebKit Commit Bot
Comment 9 2015-08-04 13:39:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.