Bug 147637

Summary:

Remove m_synchronizer from MediaPlayerPrivateMediaStream

Product:

WebKit

Reporter:

Matthew Daiter <mdaiter>

Component:

WebCore Misc.

Assignee:

Matthew Daiter <mdaiter>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, eric.carlson, jeremyj-wk, jer.noble, jonlee, mdaiter, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

PlatformOnly

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Matthew Daiter

Reported 2015-08-04 11:20:25 PDT

Need to remove this for compiles on iOS to work

Attachments
Patch (2.51 KB, patch) 2015-08-04 11:27 PDT, Matthew Daiter	no flags	Details Formatted Diff Diff
Patch (2.51 KB, patch) 2015-08-04 16:33 PDT, Matthew Daiter	no flags	Details Formatted Diff Diff
Patch (2.55 KB, patch) 2015-08-04 16:39 PDT, Matthew Daiter	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Matthew Daiter

Comment 1 2015-08-04 11:27:52 PDT

Created attachment 258187 [details] Patch

WebKit Commit Bot

Comment 2 2015-08-04 15:33:29 PDT

Comment on attachment 258187 [details] Patch Rejecting attachment 258187 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 258187, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: atform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h Hunk #1 FAILED at 154. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h.rej patching file Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/16702

WebKit Commit Bot

Comment 3 2015-08-04 16:23:53 PDT

Comment on attachment 258187 [details] Patch Rejecting attachment 258187 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 258187, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: atform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h Hunk #1 FAILED at 154. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h.rej patching file Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/16882

Matthew Daiter

Comment 4 2015-08-04 16:33:38 PDT

Created attachment 258232 [details] Patch

Matthew Daiter

Comment 5 2015-08-04 16:39:02 PDT

Created attachment 258234 [details] Patch

WebKit Commit Bot

Comment 6 2015-08-05 11:36:09 PDT

Comment on attachment 258234 [details] Patch Clearing flags on attachment: 258234 Committed r187970: <http://trac.webkit.org/changeset/187970>

WebKit Commit Bot

Comment 7 2015-08-05 11:36:12 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.