Bug 147610

Summary: [INTL] Implement Number.prototype.toLocaleString in ECMA-402
Product: WebKit Reporter: Andy VanWagoner <andy>
Component: JavaScriptCoreAssignee: Andy VanWagoner <andy>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, efidler, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 152689    
Bug Blocks: 90906    
Attachments:
Description Flags
Patch
none
Patch none

Description Andy VanWagoner 2015-08-03 17:32:41 PDT 
Implement ECMA-402 2.0 13.2.1 Number.prototype.toLocaleString ([locales [, options ]])
http://ecma-international.org/publications/standards/Ecma-402.htm

This definition supersedes the definition provided in ES2015, 20.1.3.4.
Comment 1 Andy VanWagoner 2015-12-02 21:34:28 PST 
Created attachment 266511 [details]
Patch
Comment 2 Benjamin Poulain 2015-12-03 14:27:45 PST 
Can you please fix GTK/EFL first?
Comment 3 Andy VanWagoner 2015-12-03 14:30:47 PST 
(In reply to comment #2)
> Can you please fix GTK/EFL first?

Yes, I just need to figure out why those platforms are not building NumberPrototype.js. Any ideas?
Comment 4 Andy VanWagoner 2015-12-03 15:50:23 PST 
Created attachment 266570 [details]
Patch
Comment 5 Andy VanWagoner 2015-12-03 16:49:59 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > Can you please fix GTK/EFL first?
> 
> Yes, I just need to figure out why those platforms are not building
> NumberPrototype.js. Any ideas?

I had missed CMakeLists.txt. Latest patch fixes the omission.
Comment 6 WebKit Commit Bot 2015-12-04 17:14:19 PST 
Comment on attachment 266570 [details]
Patch

Clearing flags on attachment: 266570

Committed r193493: <http://trac.webkit.org/changeset/193493>
Comment 7 WebKit Commit Bot 2015-12-04 17:14:22 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Darin Adler 2015-12-13 16:35:34 PST 
Seems likely this implementation of toLocaleString does not respect the number separator settings from the System Preferences page called Language & Region, under Advanced, on OS X. I don’t think it’s sufficient to call through to ICU without setting up ICU appropriately.
Comment 9 Darin Adler 2015-12-13 16:35:48 PST 
*** Bug 77018 has been marked as a duplicate of this bug. ***