Bug 14761

Summary: Web Inspector leaks JS objects and DOM nodes
Product: WebKit Reporter: John Moe <john>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Critical CC: aroben, timothy
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch mrowe: review+

John Moe
Reported 2007-07-24 22:01:48 PDT
Open any page, right click Inspect Element, close both windows. Lots of items will not be garbage collected (heap.numLiveObjects will be large). You can repeat and the number will continue to grow. InspectorController::m_scriptObject is never unprotected, because the call to JSObjectSetPrivate() in the InspectorController destructor causes unloading() to never call windowUnloading(). A Fix: In InspectorController.cpp, InspectorController destructor, move: m_client->inspectorDestroyed(); before: if (m_scriptContext) { and remove: m_client->closeWindow(); It seems to fix the leak and things seem to still work, but I've been playing with the WebKit code for less than a day, so who knows?
Attachments
Patch (1.72 KB, patch)
2007-11-15 22:04 PST, Timothy Hatcher 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2007-11-15 22:04:04 PST
Created attachment 17312 [details] Patch
Mark Rowe (bdash)
Comment 2 2007-11-15 22:12:46 PST
Comment on attachment 17312 [details] Patch r=me, but "Zero" should be "zero" in the changelog.
Timothy Hatcher
Comment 3 2007-11-15 22:16:17 PST
Landed in r27839. http://trac.webkit.org/projects/webkit/changeset/27839
Note You need to log in before you can comment on or make changes to this bug.