Bug 147567

Summary: Fix error handling case in Cache::dumpContentsToFile()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cgarcia, commit-queue, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2015-08-03 10:57:02 PDT 
Cache::dumpContentsToFile() was expecting openFile() to return 0 in case of error. However, it returns invalidPlatformFileHandle, which is -1 on Unix.
Comment 1 Chris Dumez 2015-08-03 10:58:20 PDT 
Created attachment 258078 [details]
Patch
Comment 2 Andreas Kling 2015-08-03 11:36:13 PDT 
Comment on attachment 258078 [details]
Patch

Whoops!
Comment 3 WebKit Commit Bot 2015-08-03 12:20:38 PDT 
Comment on attachment 258078 [details]
Patch

Clearing flags on attachment: 258078

Committed r187749: <http://trac.webkit.org/changeset/187749>
Comment 4 WebKit Commit Bot 2015-08-03 12:20:41 PDT 
All reviewed patches have been landed.  Closing bug.