Bug 147562

Summary: Make sure error handling code APIUserContentExtensionStore closes open file descriptors
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, benjamin, cgarcia, commit-queue, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2015-08-03 10:34:05 PDT
Make sure error handling code APIUserContentExtensionStore closes open file descriptors to avoid leaking them.
Attachments
Patch (3.19 KB, patch)
2015-08-03 10:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.22 KB, patch)
2015-08-03 11:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-08-03 10:35:38 PDT
Created attachment 258074 [details] Patch
Chris Dumez
Comment 2 2015-08-03 11:03:43 PDT
Created attachment 258081 [details] Patch
Alex Christensen
Comment 3 2015-08-03 14:24:12 PDT
Comment on attachment 258081 [details] Patch r=me
WebKit Commit Bot
Comment 4 2015-08-03 14:30:49 PDT
Comment on attachment 258081 [details] Patch Clearing flags on attachment: 258081 Committed r187765: <http://trac.webkit.org/changeset/187765>
WebKit Commit Bot
Comment 5 2015-08-03 14:30:53 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 6 2015-08-08 14:26:28 PDT
Comment on attachment 258081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=258081&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheData.cpp:87 > Data adoptAndMapFile(int fd, size_t offset, size_t size) Can we change the code to use a class that is like a smart pointer so we don’t have to do this kind of careful programming? It’s too easy to make these kinds of mistakes if we have to do it all manually.
Note You need to log in before you can comment on or make changes to this bug.