Bug 147521

Summary: Pass ControlStates& to RenderTheme methods instead of ControlStates*
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2015-07-31 21:08:34 PDT 
SSIA
Comment 1 zalan 2015-07-31 21:11:20 PDT 
Created attachment 257991 [details]
Patch
Comment 2 WebKit Commit Bot 2015-08-03 09:08:47 PDT 
Comment on attachment 257991 [details]
Patch

Rejecting attachment 257991 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 257991, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
meMac.mm
patching file Source/WebCore/rendering/RenderBox.cpp
Hunk #1 FAILED at 1332.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderBox.cpp.rej
patching file Source/WebCore/rendering/RenderTheme.cpp
patching file Source/WebCore/rendering/RenderTheme.h
patching file Source/WebCore/rendering/RenderThemeMac.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andreas Kling']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/11526
Comment 3 zalan 2015-08-03 09:38:05 PDT 
Created attachment 258067 [details]
Patch
Comment 4 zalan 2015-08-03 10:15:01 PDT 
Committed r187741: <http://trac.webkit.org/changeset/187741>