Bug 147518

Summary:

[GTK] LayoutTests/inspector tests timeout

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebKitGTK

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, commit-queue, hi, joepeck, tsavell, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=203746

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Patch for landing	none

Joseph Pecoraro

Reported 2015-07-31 18:17:07 PDT

* SUMMARY LayoutTests/inspector tests frequently timeout. * NOTES I'm going to skip them for now.

Attachments
Patch (3.64 KB, patch) 2019-10-14 10:09 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch for landing (25.19 KB, patch) 2019-10-25 23:48 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch for landing (22.58 KB, patch) 2019-10-30 14:09 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch for landing (19.96 KB, patch) 2019-10-30 14:15 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch for landing (19.97 KB, patch) 2019-10-30 15:04 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2015-07-31 18:17:52 PDT

The tests used to be skipped by everyone, I was able to unstop them on Mac, but it seems GTK still has issues running them.

Yury Semikhatsky

Comment 2 2019-10-14 10:09:49 PDT

Created attachment 380890 [details] Patch

Devin Rousso

Comment 3 2019-10-25 15:43:02 PDT

Comment on attachment 380890 [details] Patch rs=me

WebKit Commit Bot

Comment 4 2019-10-25 18:21:37 PDT

Comment on attachment 380890 [details] Patch Clearing flags on attachment: 380890 Committed r251621: <https://trac.webkit.org/changeset/251621>

WebKit Commit Bot

Comment 5 2019-10-25 18:21:39 PDT

All reviewed patches have been landed. Closing bug.

Yury Semikhatsky

Comment 6 2019-10-25 19:29:12 PDT

inspector/{dom,timeline} are still disabled with reference to this bug.

Yury Semikhatsky

Comment 7 2019-10-25 23:48:42 PDT

Created attachment 382004 [details] Patch for landing

WebKit Commit Bot

Comment 8 2019-10-26 00:31:32 PDT

Comment on attachment 382004 [details] Patch for landing Clearing flags on attachment: 382004 Committed r251631: <https://trac.webkit.org/changeset/251631>

WebKit Commit Bot

Comment 9 2019-10-26 00:31:33 PDT

All reviewed patches have been landed. Closing bug.

Yury Semikhatsky

Comment 10 2019-10-26 09:01:13 PDT

inspector/{dom,timeline} are still disabled with reference to this bug.

Yury Semikhatsky

Comment 11 2019-10-30 14:09:46 PDT

Created attachment 382350 [details] Patch for landing

Yury Semikhatsky

Comment 12 2019-10-30 14:15:44 PDT

Created attachment 382352 [details] Patch for landing

WebKit Commit Bot

Comment 13 2019-10-30 14:59:17 PDT

Comment on attachment 382352 [details] Patch for landing Rejecting attachment 382352 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 382352, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=382352&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=147518&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 382352 from bug 147518. Fetching: https://bugs.webkit.org/attachment.cgi?id=382352 Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/gtk/TestExpectations']" exit_code: 1 ERROR: LayoutTests/platform/gtk/TestExpectations:2385: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:2385: Path does not exist. [test/expectations] [5] Total errors found: 2 in 1 files Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/gtk/TestExpectations']" exit_code: 1 ERROR: LayoutTests/platform/gtk/TestExpectations:2385: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:2385: Path does not exist. [test/expectations] [5] Total errors found: 2 in 1 files Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/gtk/TestExpectations']" exit_code: 1 Updating OpenSource From https://git.webkit.org/git/WebKit b61d01bdab3..89d51b0a4a2 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 251799 = b61d01bdab390ffdad82fc440ad367bbdbe8a13a r251804 = 01b03238383a827aa5575a19c538a598b1eb8faf r251806 = 564dd075b55b0e4e380de77388e1ede933d7e141 r251807 = 1d802a77848c50084280e1276627338e8911b547 r251808 = 89d51b0a4a21d1a706fc84622bc73eb341e159cd Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. ERROR: LayoutTests/platform/gtk/TestExpectations:2385: Path does not exist. [test/expectations] [5] ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:2385: Path does not exist. [test/expectations] [5] Total errors found: 2 in 1 files Full output: https://webkit-queues.webkit.org/results/13192518

Yury Semikhatsky

Comment 14 2019-10-30 15:04:21 PDT

Created attachment 382362 [details] Patch for landing

WebKit Commit Bot

Comment 15 2019-10-30 16:12:21 PDT

Comment on attachment 382362 [details] Patch for landing Clearing flags on attachment: 382362 Committed r251818: <https://trac.webkit.org/changeset/251818>

WebKit Commit Bot

Comment 16 2019-10-30 16:12:23 PDT

All reviewed patches have been landed. Closing bug.

Truitt Savell

Comment 17 2019-11-01 10:41:58 PDT

It looks like the changes in https://trac.webkit.org/changeset/251818/webkit broke inspector/dom/getAccessibilityPropertiesForNode.html. Tracking in https://bugs.webkit.org/show_bug.cgi?id=203746

Note You need to log in before you can comment on or make changes to this bug.