Bug 147493

Summary:

Media Session: add test to ensure that switching media sessions pauses elements

Product:

WebKit

Reporter:

Matt Rajca <mrajca>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

conrad_shultz, eric.carlson, mrajca, webkit-bug-importer

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

145411

Attachments:

Description	Flags
Patch	eric.carlson: review+

Description Matt Rajca 2015-07-31 11:09:34 PDT

When switching media sessions, elements belonging to the old session should be paused.

Comment 1 Matt Rajca 2015-07-31 11:11:08 PDT

Created attachment 257933 [details]
Patch

Comment 2 Eric Carlson 2015-07-31 11:19:22 PDT

Comment on attachment 257933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257933&action=review

> LayoutTests/media/session/switching-sessions.html:37
> +            run('video.session = new MediaSession("transient")');
> +
> +            testExpected('video.paused', true);
> +
> +            endTest();

It might be good to register a 'pause' event handler and call endTest from there.

Comment 3 Matt Rajca 2015-07-31 22:24:56 PDT

(In reply to comment #2)
> Comment on attachment 257933 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257933&action=review
> 
> > LayoutTests/media/session/switching-sessions.html:37
> > +            run('video.session = new MediaSession("transient")');
> > +
> > +            testExpected('video.paused', true);
> > +
> > +            endTest();
> 
> It might be good to register a 'pause' event handler and call endTest from
> there.

In the case where a media element is not paused, this will be faster than letting the test time out while waiting for an event to fire. I think I'll keep this.

Comment 4 Matt Rajca 2015-07-31 22:34:47 PDT

Committed r187710: <http://trac.webkit.org/changeset/187710>