Bug 147493

Summary: Media Session: add test to ensure that switching media sessions pauses elements
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: conrad_shultz, eric.carlson, mrajca, webkit-bug-importer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145411    
Attachments:
Description Flags
Patch eric.carlson: review+

Matt Rajca
Reported 2015-07-31 11:09:34 PDT
When switching media sessions, elements belonging to the old session should be paused.
Attachments
Patch (3.75 KB, patch)
2015-07-31 11:11 PDT, Matt Rajca
eric.carlson: review+
Matt Rajca
Comment 1 2015-07-31 11:11:08 PDT
Eric Carlson
Comment 2 2015-07-31 11:19:22 PDT
Comment on attachment 257933 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257933&action=review > LayoutTests/media/session/switching-sessions.html:37 > + run('video.session = new MediaSession("transient")'); > + > + testExpected('video.paused', true); > + > + endTest(); It might be good to register a 'pause' event handler and call endTest from there.
Matt Rajca
Comment 3 2015-07-31 22:24:56 PDT
(In reply to comment #2) > Comment on attachment 257933 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257933&action=review > > > LayoutTests/media/session/switching-sessions.html:37 > > + run('video.session = new MediaSession("transient")'); > > + > > + testExpected('video.paused', true); > > + > > + endTest(); > > It might be good to register a 'pause' event handler and call endTest from > there. In the case where a media element is not paused, this will be faster than letting the test time out while waiting for an event to fire. I think I'll keep this.
Matt Rajca
Comment 4 2015-07-31 22:34:47 PDT
Note You need to log in before you can comment on or make changes to this bug.