Summary: | REGRESSION: Inline-block baseline is wrong when zero-width replaced child is present | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, mmaxfield | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dave Hyatt
2015-07-30 12:44:38 PDT
Created attachment 257846 [details]
Patch
Comment on attachment 257846 [details]
Patch
r=me
Comment on attachment 257846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257846&action=review > Source/WebCore/rendering/line/LineWidth.h:62 > + bool hasCommitted() { return m_committedWidth > 0 || m_hasCommittedReplaced; } const > Source/WebCore/rendering/line/LineWidth.h:100 > + bool m_hasUncommittedReplaced; > + bool m_hasCommittedReplaced; Would be nice to use initializers here bool m_hasUncommittedReplaced { false }; etc. Maybe convert them all. (In reply to comment #4) > Landed in r189540. !! :D |