Bug 147447

Summary: jsc-tailcall: Don't waste stack space when arity fixup was performed
Product: WebKit Reporter: Basile Clement <basile_clement>
Component: JavaScriptCoreAssignee: Basile Clement <basile_clement>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, mark.lam, mmirman, msaboff, saam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146477    
Attachments:
Description Flags
Patch
none
Patch
none
Patch msaboff: review+

Description Basile Clement 2015-07-30 10:53:39 PDT 
Currently when doing a tail call we overwrite only the number of arguments present in the call frame. However, we could have performed an arity fixup and must use the CodeBlock's number of parameters instead if it is higher.
Comment 1 Basile Clement 2015-07-30 10:56:36 PDT 
Created attachment 257840 [details]
Patch
Comment 2 Michael Saboff 2015-07-30 13:43:29 PDT 
Comment on attachment 257840 [details]
Patch

r=me
Comment 3 Basile Clement 2015-07-30 16:19:49 PDT 
Landed in r187618
Comment 4 Basile Clement 2015-07-31 12:13:52 PDT 
This is missing the LLInt corresponding changes.
Comment 5 Basile Clement 2015-07-31 12:59:26 PDT 
*** Bug 147491 has been marked as a duplicate of this bug. ***
Comment 6 Basile Clement 2015-07-31 13:13:09 PDT 
Created attachment 257950 [details]
Patch
Comment 7 Basile Clement 2015-07-31 13:21:06 PDT 
Created attachment 257953 [details]
Patch
Comment 8 Michael Saboff 2015-07-31 13:25:09 PDT 
Comment on attachment 257953 [details]
Patch

r=me
Comment 9 Basile Clement 2015-07-31 13:32:20 PDT 
Committed r187676 <http://trac.webkit.org/changeset/187676>