Bug 147430

Summary: Clean up makeFontCascadeCacheKey()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, commit-queue, dino, jonlee, koivisto, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 147427    
Bug Blocks: 147457    
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2015-07-29 18:47:59 PDT
Clean up makeFontCascadeCacheKey()
Attachments
Patch (4.82 KB, patch)
2015-07-29 18:51 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (4.76 KB, patch)
2015-07-30 14:47 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-07-29 18:51:46 PDT
Created attachment 257799 [details] Patch
Myles C. Maxfield
Comment 2 2015-07-30 14:47:24 PDT
Created attachment 257855 [details] Patch
Benjamin Poulain
Comment 3 2015-07-30 15:17:21 PDT
Comment on attachment 257855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257855&action=review > Source/WebCore/platform/graphics/FontCache.h:85 > + return static_cast<unsigned>(description.script()) << 9 > + | static_cast<unsigned>(description.smallCaps()) << 8 > + | static_cast<unsigned>(description.fontSynthesis()) << 6 This seems so fragile :( But I can't find a better way :(
WebKit Commit Bot
Comment 4 2015-07-30 16:07:16 PDT
Comment on attachment 257855 [details] Patch Clearing flags on attachment: 257855 Committed r187615: <http://trac.webkit.org/changeset/187615>
WebKit Commit Bot
Comment 5 2015-07-30 16:07:27 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 6 2015-09-24 18:53:34 PDT
Rolled out in <https://trac.webkit.org/r190232> because it seems to have caused a >1% regression on PLT (see rdar://problem/22657123).
Beth Dakin
Comment 7 2015-09-24 22:12:11 PDT
(In reply to comment #6) > Rolled out in <https://trac.webkit.org/r190232> because it seems to have > caused a >1% regression on PLT (see rdar://problem/22657123). This rollout seems to have caused fast/css3-text/font-synthesis.html to start failing.
Beth Dakin
Comment 8 2015-09-24 22:15:43 PDT
I marked the test as failing for now: http://trac.webkit.org/changeset/190236
Chris Dumez
Comment 9 2015-09-25 09:12:39 PDT
Remanded in <http://trac.webkit.org/changeset/190242> as the rollout did not help the PLT recover.
Note You need to log in before you can comment on or make changes to this bug.