| Summary: | Clean up makeFontCascadeCacheKey() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bdakin, cdumez, commit-queue, dino, jonlee, koivisto, simon.fraser, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 147427 | ||||||||
| Bug Blocks: | 147457 | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2015-07-29 18:47:59 PDT
Created attachment 257799 [details]
Patch
Created attachment 257855 [details]
Patch
Comment on attachment 257855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257855&action=review > Source/WebCore/platform/graphics/FontCache.h:85 > + return static_cast<unsigned>(description.script()) << 9 > + | static_cast<unsigned>(description.smallCaps()) << 8 > + | static_cast<unsigned>(description.fontSynthesis()) << 6 This seems so fragile :( But I can't find a better way :( Comment on attachment 257855 [details] Patch Clearing flags on attachment: 257855 Committed r187615: <http://trac.webkit.org/changeset/187615> All reviewed patches have been landed. Closing bug. Rolled out in <https://trac.webkit.org/r190232> because it seems to have caused a >1% regression on PLT (see rdar://problem/22657123). (In reply to comment #6) > Rolled out in <https://trac.webkit.org/r190232> because it seems to have > caused a >1% regression on PLT (see rdar://problem/22657123). This rollout seems to have caused fast/css3-text/font-synthesis.html to start failing. I marked the test as failing for now: http://trac.webkit.org/changeset/190236 Remanded in <http://trac.webkit.org/changeset/190242> as the rollout did not help the PLT recover. |