Bug 147414 – Media Session: test Play/Pause media control events delivered to non-Content media sessions

• Component: Media
• Status: RESOLVED FIXED

[Matt Rajca]

Add tests to ensure that Transient, Transient Solo, and Ambient media sessions don't respond to media control events.

[Radar WebKit Bug Importer]

<rdar://problem/22056208>

[Matt Rajca]

Created attachment 257774 [details]
Patch

[Eric Carlson]

Comment on attachment 257774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257774&action=review

> LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:31
> +            video.play();

Nit: If you want to add the event listener with "video.on<event type>", I think it will make the test results easier to understand if you log the event name as you would if you used waitForEvent, eg:

consoleWrite("EVENT(" + event.type + ")");

> LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:62
> +    <p>'Transient' sessions should not respond to Play/Pause media control events.</p>

You are testing both transient and ambient sessions.

[Matt Rajca]

(In reply to comment #3)
> Comment on attachment 257774 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257774&action=review
> 
> > LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:31
> > +            video.play();
> 
> Nit: If you want to add the event listener with "video.on<event type>", I
> think it will make the test results easier to understand if you log the
> event name as you would if you used waitForEvent, eg:
> 
> consoleWrite("EVENT(" + event.type + ")");

I switched to `waitForEvent`.

> 
> > LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:62
> > +    <p>'Transient' sessions should not respond to Play/Pause media control events.</p>
> 
> You are testing both transient and ambient sessions.

Good catch.

[Matt Rajca]

Committed r187612: <http://trac.webkit.org/changeset/187612>