Bug 147399

Summary: Rename AVPlayerLayerView to _AVPlayerLayerView.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jeremy Jones 2015-07-28 21:32:17 PDT 
Rename AVPlayerLayerView to _AVPlayerLayerView.
Comment 1 Jeremy Jones 2015-07-28 21:46:28 PDT 
rdar://problem/22000865
Comment 2 Jeremy Jones 2015-07-31 11:18:37 PDT 
Created attachment 257934 [details]
Patch
Comment 3 Jeremy Jones 2015-07-31 11:19:13 PDT 
Actually rename it to __AVPlayerLayerView
Comment 4 Jeremy Jones 2015-07-31 11:24:39 PDT 
Created attachment 257935 [details]
Patch
Comment 5 Eric Carlson 2015-07-31 14:01:48 PDT 
Comment on attachment 257935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257935&action=review

> Source/WebCore/ChangeLog:3
> +        Rename AVPlayerLayerView to _AVPlayerLayerView.

Nit: you added two underscores to the name - "__AVPlayerLayerView"
Comment 6 Jeremy Jones 2015-07-31 14:48:07 PDT 
(In reply to comment #5)
> Comment on attachment 257935 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257935&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Rename AVPlayerLayerView to _AVPlayerLayerView.
> 
> Nit: you added two underscores to the name - "__AVPlayerLayerView"

Intentional. That is the actual name AVKit decided on.
Comment 7 WebKit Commit Bot 2015-07-31 15:20:38 PDT 
Comment on attachment 257935 [details]
Patch

Clearing flags on attachment: 257935

Committed r187684: <http://trac.webkit.org/changeset/187684>
Comment 8 WebKit Commit Bot 2015-07-31 15:20:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Eric Carlson 2015-08-01 09:05:53 PDT 
(In reply to comment #6)
> (In reply to comment #5)
> > Comment on attachment 257935 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=257935&action=review
> > 
> > > Source/WebCore/ChangeLog:3
> > > +        Rename AVPlayerLayerView to _AVPlayerLayerView.
> > 
> > Nit: you added two underscores to the name - "__AVPlayerLayerView"
> 
> Intentional. That is the actual name AVKit decided on.

Yes, but the comment in the change log only has a single underscore.