Bug 147399

Summary: Rename AVPlayerLayerView to _AVPlayerLayerView.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jeremy Jones
Reported 2015-07-28 21:32:17 PDT
Rename AVPlayerLayerView to _AVPlayerLayerView.
Attachments
Patch (5.89 KB, patch)
2015-07-31 11:18 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (5.92 KB, patch)
2015-07-31 11:24 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2015-07-28 21:46:28 PDT
rdar://problem/22000865
Jeremy Jones
Comment 2 2015-07-31 11:18:37 PDT
Created attachment 257934 [details] Patch
Jeremy Jones
Comment 3 2015-07-31 11:19:13 PDT
Actually rename it to __AVPlayerLayerView
Jeremy Jones
Comment 4 2015-07-31 11:24:39 PDT
Created attachment 257935 [details] Patch
Eric Carlson
Comment 5 2015-07-31 14:01:48 PDT
Comment on attachment 257935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257935&action=review > Source/WebCore/ChangeLog:3 > + Rename AVPlayerLayerView to _AVPlayerLayerView. Nit: you added two underscores to the name - "__AVPlayerLayerView"
Jeremy Jones
Comment 6 2015-07-31 14:48:07 PDT
(In reply to comment #5) > Comment on attachment 257935 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257935&action=review > > > Source/WebCore/ChangeLog:3 > > + Rename AVPlayerLayerView to _AVPlayerLayerView. > > Nit: you added two underscores to the name - "__AVPlayerLayerView" Intentional. That is the actual name AVKit decided on.
WebKit Commit Bot
Comment 7 2015-07-31 15:20:38 PDT
Comment on attachment 257935 [details] Patch Clearing flags on attachment: 257935 Committed r187684: <http://trac.webkit.org/changeset/187684>
WebKit Commit Bot
Comment 8 2015-07-31 15:20:42 PDT
All reviewed patches have been landed. Closing bug.
Eric Carlson
Comment 9 2015-08-01 09:05:53 PDT
(In reply to comment #6) > (In reply to comment #5) > > Comment on attachment 257935 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=257935&action=review > > > > > Source/WebCore/ChangeLog:3 > > > + Rename AVPlayerLayerView to _AVPlayerLayerView. > > > > Nit: you added two underscores to the name - "__AVPlayerLayerView" > > Intentional. That is the actual name AVKit decided on. Yes, but the comment in the change log only has a single underscore.
Note You need to log in before you can comment on or make changes to this bug.