Bug 147395

Summary:

[GTK] Missing casts in BrowserWindow.c

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebKitGTK

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue, mcatanzaro

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none

Description Michael Catanzaro 2015-07-28 18:45:33 PDT

../../Tools/MiniBrowser/gtk/BrowserWindow.c:817:22: warning: incompatible pointer types assigning to 'GtkWidget *' (aka 'struct _GtkWidget *') from 'GtkToolItem *' (aka 'struct _GtkToolItem *') [-Wincompatible-pointer-types]
    window->boldItem = item;
                     ^ ~~~~
../../Tools/MiniBrowser/gtk/BrowserWindow.c:824:24: warning: incompatible pointer types assigning to 'GtkWidget *' (aka 'struct _GtkWidget *') from 'GtkToolItem *' (aka 'struct _GtkToolItem *') [-Wincompatible-pointer-types]
    window->italicItem = item;
                       ^ ~~~~
../../Tools/MiniBrowser/gtk/BrowserWindow.c:831:27: warning: incompatible pointer types assigning to 'GtkWidget *' (aka 'struct _GtkWidget *') from 'GtkToolItem *' (aka 'struct _GtkToolItem *') [-Wincompatible-pointer-types]
    window->underlineItem = item;
                          ^ ~~~~
../../Tools/MiniBrowser/gtk/BrowserWindow.c:839:31: warning: incompatible pointer types assigning to 'GtkWidget *' (aka 'struct _GtkWidget *') from 'GtkToolItem *' (aka 'struct _GtkToolItem *') [-Wincompatible-pointer-types]
    window->strikethroughItem = item;
                              ^ ~~~~

Comment 1 Michael Catanzaro 2015-07-28 20:10:58 PDT

Created attachment 257727 [details]
Patch

Comment 2 WebKit Commit Bot 2015-07-28 23:48:39 PDT

Comment on attachment 257727 [details]
Patch

Clearing flags on attachment: 257727

Committed r187541: <http://trac.webkit.org/changeset/187541>

Comment 3 WebKit Commit Bot 2015-07-28 23:48:44 PDT

All reviewed patches have been landed.  Closing bug.