Summary: | [WK2][iOS] WebContent process main thread should have fixed priority | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough, kling, rniwa, sam | ||||||||
Priority: | P1 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | iPhone / iPad | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Chris Dumez
2015-07-26 20:50:55 PDT
Created attachment 257541 [details]
Patch
Comment on attachment 257541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257541&action=review > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:176 > + if (parameters.uiProcessBundleIdentifier == "com.apple.mobilesafari") Why only for MobileSafari? If this is a good idea for MobileSafari, why isn't it a good idea all he time? (In reply to comment #3) > Comment on attachment 257541 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257541&action=review > > > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:176 > > + if (parameters.uiProcessBundleIdentifier == "com.apple.mobilesafari") > > Why only for MobileSafari? If this is a good idea for MobileSafari, why > isn't it a good idea all he time? Please see radar for more information. Created attachment 257542 [details]
Patch
(In reply to comment #3) > Comment on attachment 257541 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257541&action=review > > > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:176 > > + if (parameters.uiProcessBundleIdentifier == "com.apple.mobilesafari") > > Why only for MobileSafari? If this is a good idea for MobileSafari, why > isn't it a good idea all he time? I removed the check as discussed offline. Comment on attachment 257542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257542&action=review Yuck. > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:173 > +#if (TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000) No need for the parentheses. Created attachment 257544 [details]
Patch
Comment on attachment 257544 [details] Patch Clearing flags on attachment: 257544 Committed r187412: <http://trac.webkit.org/changeset/187412> All reviewed patches have been landed. Closing bug. |