Bug 147299

Summary:

aria-liveregions-notifications tests are very flaky

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=147211

Attachments:

Description	Flags
patch	cfleizach: review-
patch	none

Description Alexey Proskuryakov 2015-07-25 18:00:13 PDT

aria-liveregions-notifications tests are very flaky, failing most of the time on debug bots:

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=platform%2Fmac%2Faccessibility%2Faria-liveregions-notifications

Comment 1 Radar WebKit Bug Importer 2015-07-25 18:00:25 PDT

<rdar://problem/21998675>

Comment 2 Alexey Proskuryakov 2015-07-25 18:03:20 PDT

Added test expectations in r187394 (this means that test results are almost ignored, and we will only get a failure notification if they begin to crash).

Comment 3 Nan Wang 2015-07-29 17:07:05 PDT

Created attachment 257786 [details]
patch

Comment 4 chris fleizach 2015-07-30 10:58:28 PDT

Comment on attachment 257786 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257786&action=review

just need a comment update. thanks

> LayoutTests/ChangeLog:9
> +        Previous tests were flaky that results were relying on a timer based notification. Fixed the tests by

These tests were flaky because they relied on timer notification callbacks. 
Fixed these tests by using different objects to capture the notifications instead

Comment 5 Nan Wang 2015-07-30 11:06:57 PDT

Created attachment 257841 [details]
patch

Comment 6 WebKit Commit Bot 2015-07-30 11:39:48 PDT

Comment on attachment 257841 [details]
patch

Clearing flags on attachment: 257841

Committed r187595: <http://trac.webkit.org/changeset/187595>

Comment 7 WebKit Commit Bot 2015-07-30 11:39:52 PDT

All reviewed patches have been landed.  Closing bug.