Bug 147237

Summary:

Should not allow previews of 1x1 images

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Beth Dakin 2015-07-23 13:39:04 PDT

We should not allow previews of 1x1 images

Comment 1 Beth Dakin 2015-07-23 13:42:39 PDT

Created attachment 257373 [details]
Patch

Comment 2 Tim Horton 2015-07-23 13:45:14 PDT

Comment on attachment 257373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257373&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2226
> +                                info.imageURL = [(NSURL *)element->document().completeURL(renderImage.cachedImage()->url()) absoluteString];

We really need to helper function the crap out of this beast.

Comment 3 Beth Dakin 2015-07-23 13:55:39 PDT

Thanks Tim! http://trac.webkit.org/changeset/187250