Bug 147237

Summary: Should not allow previews of 1x1 images
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Beth Dakin
Reported 2015-07-23 13:39:04 PDT
We should not allow previews of 1x1 images
Attachments
Patch (4.22 KB, patch)
2015-07-23 13:42 PDT, Beth Dakin 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2015-07-23 13:42:39 PDT
Created attachment 257373 [details] Patch
Tim Horton
Comment 2 2015-07-23 13:45:14 PDT
Comment on attachment 257373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257373&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2226 > + info.imageURL = [(NSURL *)element->document().completeURL(renderImage.cachedImage()->url()) absoluteString]; We really need to helper function the crap out of this beast.
Beth Dakin
Comment 3 2015-07-23 13:55:39 PDT
Thanks Tim! http://trac.webkit.org/changeset/187250
Note You need to log in before you can comment on or make changes to this bug.