Bug 147234

Summary: Relax media playback restrictions if the allowsMediaDocumentInlinePlayback property is set.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 147181    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch darin: review+

Jer Noble
Reported 2015-07-23 12:54:35 PDT
Relax media playback restrictions if the allowsMediaDocumentInlinePlayback property is set.
Attachments
Patch (4.83 KB, patch)
2015-07-23 13:45 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (4.83 KB, patch)
2015-07-23 14:24 PDT, Jer Noble 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2015-07-23 13:45:23 PDT
Created attachment 257374 [details] Patch
Jer Noble
Comment 2 2015-07-23 14:24:07 PDT
Created attachment 257383 [details] Patch
Darin Adler
Comment 3 2015-07-23 14:28:27 PDT
Comment on attachment 257383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257383&action=review > Source/WebCore/html/MediaElementSession.cpp:124 > + Page* page = element.document().page(); > + if (element.document().isMediaDocument() && !element.document().ownerElement() && page && page->allowsMediaDocumentInlinePlayback()) > + return true; Helper function for this? The code is repeated three times. I would put element.document() into a local variable since we use it three times.
Jer Noble
Comment 4 2015-07-23 15:24:59 PDT
Committed r187262: <http://trac.webkit.org/changeset/187262>
Note You need to log in before you can comment on or make changes to this bug.